Skip to content

Commit

Permalink
We still can't upgrade to protocol 23
Browse files Browse the repository at this point in the history
  • Loading branch information
2opremio committed Feb 6, 2025
1 parent f008b22 commit 63b0d98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/stellar-rpc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ jobs:
STELLAR_RPC_INTEGRATION_TESTS_ENABLED: true
STELLAR_RPC_INTEGRATION_TESTS_CORE_MAX_SUPPORTED_PROTOCOL: ${{ matrix.protocol-version }}
STELLAR_RPC_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core
PROTOCOL_22_CORE_DEBIAN_PKG_VERSION: 22.1.0-2194.0241e79f7.focal
PROTOCOL_22_CORE_DOCKER_IMG: stellar/stellar-core:22.1.0-2194.0241e79f7.focal
PROTOCOL_23_CORE_DEBIAN_PKG_VERSION: 22.1.1-2251.ac9f21ac7.focal~do~not~use~in~prd
PROTOCOL_23_CORE_DOCKER_IMG: stellar/unsafe-stellar-core:22.1.1-2251.ac9f21ac7.focal-do-not-use-in-prd
PROTOCOL_21_CORE_DEBIAN_PKG_VERSION: 22.1.0-2194.0241e79f7.focal
PROTOCOL_21_CORE_DOCKER_IMG: stellar/stellar-core:22.1.0-2194.0241e79f7.focal
PROTOCOL_22_CORE_DEBIAN_PKG_VERSION: 22.1.1-2251.ac9f21ac7.focal~do~not~use~in~prd
PROTOCOL_22_CORE_DOCKER_IMG: stellar/unsafe-stellar-core:22.1.1-2251.ac9f21ac7.focal-do-not-use-in-prd

steps:
- uses: actions/checkout@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ func NewTest(t *testing.T, cfg *TestConfig) *Test {
i.enableCoreHTTPQueryServer = cfg.EnableCoreHTTPQueryServer
}

if i.enableCoreHTTPQueryServer && GetCoreMaxSupportedProtocol() < 23 {
t.Skip("Core's HTTP Query server is only available from protocol 23")
if i.enableCoreHTTPQueryServer && GetCoreMaxSupportedProtocol() < 22 {
t.Skip("Core's HTTP Query server is only available from protocol 22")
}

if i.sqlitePath == "" {
Expand Down

0 comments on commit 63b0d98

Please sign in to comment.