-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-1: Add SEP-45 fields #1579
base: master
Are you sure you want to change the base?
SEP-1: Add SEP-45 fields #1579
Conversation
7dd639a
to
09fc6d9
Compare
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
09fc6d9
to
bf3ab15
Compare
bf3ab15
to
6a48f74
Compare
| TRANSFER_SERVER_SEP0024 | uses `https://` | The server used for [SEP-24](sep-0024.md) Anchor/Client interoperability | | ||
| KYC_SERVER | uses `https://` | The server used for [SEP-12](sep-0012.md) Anchor/Client customer info transfer | | ||
| WEB_AUTH_ENDPOINT | uses `https://` | The endpoint used for [SEP-10 Web Authentication](sep-0010.md) | | ||
| WEB_AUTH_FOR_CONTRACTS_ENDPOINT | uses `https://` | The endpoint used for [SEP-45 Web Authentication](sep-0045.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use SOROBAN
in most of the CAPs. For example,
stellar-protocol/core/README.md
Line 58 in 3d4fde9
| [CAP-0046](cap-0046.md) | 20 |Soroban smart contract system overview | Graydon Hoare | Final | |
Do we consider rename this to
| WEB_AUTH_FOR_CONTRACTS_ENDPOINT | uses `https://` | The endpoint used for [SEP-45 Web Authentication](sep-0045.md) | | |
| WEB_AUTH_FOR_SOROBAN_ENDPOINT | uses `https://` | The endpoint used for [SEP-45 Web Authentication](sep-0045.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically avoid using Soroban unless specifically referring to the smart contract environment on Stellar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this for the smart contract? Can you give examples where Soroban is avoided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, we call them "Stellar smart contracts" in the docs https://developers.stellar.org/docs/build/smart-contracts/getting-started/setup. Also, WEB_AUTH_FOR_CONTRACTS_ENDPOINT
is already used by the SEP-45 draft.
No description provided.