Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp field to mgi raw table #255

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Add timestamp field to mgi raw table #255

merged 8 commits into from
Dec 1, 2023

Conversation

cayod
Copy link
Contributor

@cayod cayod commented Nov 24, 2023

This PR adds a timestamp field to the raw_mgi_stellar_transactions table, this field will be used in the task for data quality checks with the Elementary.

@cayod cayod requested a review from a team as a code owner November 24, 2023 16:22
lucaszanotelli
lucaszanotelli reviewed Nov 24, 2023
View reviewed changes
dags/partner_pipeline_dag.py Outdated Show resolved Hide resolved
schemas/raw_mgi_stellar_transactions_schema.json Outdated Show resolved Hide resolved
sydneynotthecity
sydneynotthecity approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you need me to alter the production table to add the same default?

@cayod
Copy link
Contributor Author

cayod commented Dec 1, 2023

Will you need me to alter the production table to add the same default?

I will try here and let you know if needed

@cayod cayod merged commit a64ca96 into master Dec 1, 2023
4 checks passed
@lucaszanotelli lucaszanotelli deleted the timestamp-mgi branch December 1, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaszanotelli lucaszanotelli lucaszanotelli left review comments

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cayod @sydneynotthecity @lucaszanotelli