Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how-to-issue-an-asset.mdx #1221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update how-to-issue-an-asset.mdx #1221

wants to merge 1 commit into from

Conversation

Eduard-Voiculescu
Copy link
Contributor

@Eduard-Voiculescu Eduard-Voiculescu commented Jan 22, 2025 •
edited
Loading

Changes to code snippet in Golang to reflect changes done to the stellar libs

@ElliotFriend
Copy link
Contributor

@Eduard-Voiculescu thanks for the contribution! I'm handing off review to @carstenjacobsen, since he's more experienced in Go than myself.

carstenjacobsen
carstenjacobsen reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@carstenjacobsen carstenjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes to the SourceAccount parameter should not be necessary, since the object returned by the protocol.Account already conforms to the interface required by the SourceAccount parameter.

carstenjacobsen
carstenjacobsen reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@carstenjacobsen carstenjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the Timebounds parameter looks fine

@Eduard-Voiculescu
Copy link
Contributor Author

Hey @carstenjacobsen, let me recheck maybe there is something I missed.

@Eduard-Voiculescu
Copy link
Contributor Author

Ok I missed the change, you are right. I have removed my changes regarding the SourceAccounts. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carstenjacobsen carstenjacobsen carstenjacobsen left review comments

@ElliotFriend ElliotFriend Awaiting requested review from ElliotFriend

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eduard-Voiculescu @ElliotFriend @carstenjacobsen