Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented the Lesson 5 in Cargo.toml #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedro-pelicioni
Copy link

Me And @Row-Bear needed to comment on Lesson 5 for it to actually compile. From what we've seen, it could be that it's out of date, and that could lead to at least 13 errors if we don't comment on it.

@Row-Bear
Copy link
Contributor

I don't think the errors are due to things being out of date. Quest 5 needs the user to write parts of the contract before it can compile, so it's expected to not compile yet.
The user experience for those starting with quest 1 though is a bit jarring, since 'soroban contract build' will try to compile the entire workspace.
Commenting quest 5 out from the TOML is one way to prevent it, but then we'd need to guide the user towards uncommenting that during quest 5.
There may be other alternatives to avoid this, I don't know.

@pedro-pelicioni
Copy link
Author

I agree ! @Row-Bear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants