-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hf20 testnet appbase #4
Changes from 9 commits
3ecfa8b
77693fc
3c5a635
1ac3eca
1b93c2c
f911d8d
7e79b13
8f9d8dd
5afd631
2910029
5df4b7d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,9 +50,10 @@ export type OperationName = // <id> | |
| 'account_witness_proxy' // 13 | ||
| 'account_witness_vote' // 12 | ||
| 'cancel_transfer_from_savings' // 34 | ||
| 'challenge_authority' // 22 | ||
| 'change_recovery_account' // 26 | ||
| 'claim_account' // 22 | ||
| 'claim_reward_balance' // 39 | ||
| 'create_claimed_account' // 23 | ||
| 'comment' // 1 | ||
| 'comment_options' // 19 | ||
| 'convert' // 8 | ||
|
@@ -72,7 +73,6 @@ export type OperationName = // <id> | |
| 'limit_order_create2' // 21 | ||
| 'pow' // 14 | ||
| 'pow2' // 30 | ||
| 'prove_authority' // 23 | ||
| 'recover_account' // 25 | ||
| 'report_over_production' // 16 | ||
| 'request_account_recovery' // 24 | ||
|
@@ -194,15 +194,6 @@ export interface CancelTransferFromSavingsOperation extends Operation { | |
} | ||
} | ||
|
||
export interface ChallengeAuthorityOperation extends Operation { | ||
0: 'challenge_authority' // 22 | ||
1: { | ||
challenger: string // account_name_type | ||
challenged: string // account_name_type | ||
require_owner: boolean | ||
} | ||
} | ||
|
||
/** | ||
* Each account lists another account as their recovery account. | ||
* The recovery account has the ability to create account_recovery_requests | ||
|
@@ -249,6 +240,18 @@ export interface ClaimRewardBalanceOperation extends Operation { | |
} | ||
} | ||
|
||
export interface ClaimAccountOperation extends Operation { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Operation needs to be documented. |
||
0: 'claim_account' // 22 | ||
1: { | ||
creator: string // account_name_type | ||
fee: string | Asset | ||
/** | ||
* Extensions. Not currently used. | ||
*/ | ||
extensions: any[] // extensions_type | ||
} | ||
} | ||
|
||
export interface CommentOperation extends Operation { | ||
0: 'comment' // 1 | ||
1: { | ||
|
@@ -288,6 +291,23 @@ export interface ConvertOperation extends Operation { | |
} | ||
} | ||
|
||
export interface CreateClaimedAccountOperation extends Operation { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Operation needs to be documented. |
||
0: 'create_claimed_account' // 23 | ||
1: { | ||
creator: string // account_name_type | ||
new_account_name: string // account_name_type | ||
owner: AuthorityType | ||
active: AuthorityType | ||
posting: AuthorityType | ||
memo_key: string | PublicKey // public_key_type | ||
json_metadata: string | ||
/** | ||
* Extensions. Not currently used. | ||
*/ | ||
extensions: any[] // extensions_type | ||
} | ||
} | ||
|
||
export interface CustomOperation extends Operation { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Operation needs to be documented. |
||
0: 'custom' // 15 | ||
1: { | ||
|
@@ -547,14 +567,6 @@ export interface Pow2Operation extends Operation { | |
} | ||
} | ||
|
||
export interface ProveAuthorityOperation extends Operation { | ||
0: 'prove_authority' // 23 | ||
1: { | ||
challenged: string // account_name_type | ||
require_owner: boolean | ||
} | ||
} | ||
|
||
/** | ||
* Recover an account to a new authority using a previous authority and verification | ||
* of the recovery account as proof of identity. This operation can only succeed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assignments could be an issue.
addressPrefix
&chainId
are not guaranteed on any testnet, includingtestnet.steemitdev.com
; in fact there are explicit stories and direction on the dev portal about the chain id changing to something derived from the current git-hash.We need to have these update only-if-not-set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for smallest set of changes in this PR, let's revisit this later. Still need to figure out how we'll handle it in the other clients too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we need to address this need in other clients as well, but that's not relevant here.
Added issue #5 to track our needs, and approving to keep the flow going.