Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF20 account creation operations #2

Closed
wants to merge 6 commits into from

Conversation

roadscape
Copy link

Changes

  • adds claim_account and create_claimed_account
  • removes challenge_authority and prove_authority

Unresolved

  • what to do with createAccount(options: CreateAccountOptions, key: PrivateKey) in helpers/broadcast.ts?
    • is it used anywhere?
    • to upgrade, would need two paths
      1. create account with fee, then delegate SP
      2. create claimed account, then delegate SP

@bnchdrff bnchdrff self-requested a review September 4, 2018 17:24
@bnchdrff
Copy link

bnchdrff commented Sep 4, 2018

i think we should increase the major version by 1 and remove createAccount - it's a significant enough change right?

@roadscape roadscape changed the base branch from master to appbase-and-testnet September 17, 2018 16:34
@jnordberg
Copy link

LGTM 👍

@roadscape
Copy link
Author

Replaced with #4

@roadscape roadscape closed this Sep 20, 2018
@roadscape roadscape deleted the hf20-accounts branch September 24, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants