-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#proposal 86 tags and mobile #3934
Open
the-gorilla-steem
wants to merge
8
commits into
steemit:master
Choose a base branch
from
the-gorilla-steem:#proposal-86-tags-and-mobile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#proposal 86 tags and mobile #3934
the-gorilla-steem
wants to merge
8
commits into
steemit:master
from
the-gorilla-steem:#proposal-86-tags-and-mobile
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of a "Back to top" icon in the bottom right corner on Desktop devices. Currently only on Desktop due to the design / implementation challenge on mobile devices.
Removed the "overflow: hidden" from the .App_content style in Apps.scss so that any overlays do not get cropped when opened. Bug Fix steemit#3931
Implemented the Community Carousel in Communities on Mobile Devices. Users no long need to scroll past lots of pinned posts before seeing community content.
Updated the link structure to improve SEO for community content. Instead of 'hive-xxxxxx' in the URL, this is replaced by the communtiy name (switched to lower case and special characters removed/updated) or if this is invalid, the 1st tag of the user content. This update also includes implementation of updated 'canonical-url' information so that Google prioritises the more SEO friendly URL.
Introduced a check on the 'settings' object (in Community Settings) so that it's not an empty object. If no 'avatar_url' or 'cover_url' is set, the object will now reflect this.
Introduced a getTags request to retrieve Tags information from Hivemind in order to get the /tags page working again. This is currently hard coded to retrieve (the maximum of) 250 tags but should be configured to accept this number as a variable to allow for the future implementation of a Tag Cloud or other functionality. Community tags (i.e. 'hive-xxxxxx) are currently filtered out of the /Tags page but a future update could introduce these as their own section.
Update nodes (steemit#3933)
@ety001 - Could you please deploy this to steemitdev for me? Could you also check Hivemind since the data on steemitdev has not been updated for 21 days (likely caused by this - steemit/hivemind#345) |
Fix for bug steemit#3935 so that the Preview clears the floating Markdown Style Guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Community Carousel on Mobile devices
Updated the URL structure and corresponding Canonical URL to improve SEO
Implemented 'Back-to-top' on Desktop
Fixed the '/tags' page
Fixed Bug Payout dropdown menu is cut off at the bottom #3931
Fixed Bug UpdateProps of community settings is rejected by Hivemind as invalid #3932