Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate stats/base/dnanmeanors to stats/strided/dnanmeanors #5441

Closed

Conversation

Neerajpathak07
Copy link
Contributor

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the dnanmeanors package from stats/base to stats/strided to support strided array functionality.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Feb 25, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/strided/dnanmeanors $\color{green}363/363$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}363/363$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 25, 2025 07:57
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 25, 2025
@kgryte kgryte added Do Not Merge Pull request which should not be merged. and removed Needs Review A pull request which needs code review. labels Feb 25, 2025
@kgryte
Copy link
Member

kgryte commented Feb 25, 2025

Unfortunately, this is not what we are looking for for package migrations. As such, I'll need to go ahead and close. There is a very specific sequence of commits that is required in order to ensure proper changelog generation and ensure that downstream packages within stdlib are not broken.

@kgryte kgryte closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Pull request which should not be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants