feat: add C ndarray implementation for blas/base/zscal
#4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
stdlib-bot
added
the
BLAS
Coverage Report
The above coverage report was generated for the changes in this PR. |
aman-095
added
Feature
kgryte
reviewed
Jan 25, 2025
| var ix; | ||
| var i; | ||
|
|
||
| if ( N <= 0 ) { | ||
| return zx; | ||
| } | ||
| // Reinterpret the input array as a real-valued array of interleaved real and imaginary components: | ||
| view = reinterpret( zx, 0 ); |
There was a problem hiding this comment.
@aman-095 Please revert this refactoring. I just recently updated this to avoid complex number instantiation. Don't simply copy-paste from cscal.
kgryte
reviewed
Jan 25, 2025
| @@ -32,7 +32,7 @@ var ndarray = require( './ndarray.js' ); | |||
| * @param {PositiveInteger} N - number of indexed elements | |||
| * @param {Complex128} za - constant | |||
| * @param {Complex128Array} zx - input array | |||
| * @param {integer} strideZX - `zx` stride length | |||
| * @param {integer} strideX - `zx` stride length | |||
There was a problem hiding this comment.
FTR, I recently changed these: c97212e#diff-1135e703968b45bc6a897ad9dc728fb0d90a6b633a520e9c455d7bc6c13a78caR36
Namely, because we are not consistent. Personally, instead of za and zx, I'd prefer if we just used alpha and x for both real and complex. The use of za, ca, etc, stems from Fortran in order to signal the dtype. I think we just create more work for ourselves when going from real to complex by following suit and renaming variables from x to cx or zx. The function name and the C type signatures are enough to convey what is expected. I don't think we need to encode the type info directly into the parameter names themselves.
kgryte
reviewed
Jan 25, 2025
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function supports a negative `zx` stride', function test( t ) { |
There was a problem hiding this comment.
@aman-095 Why is this added given L250 which tests the same thing?
kgryte
requested changes
Jan 25, 2025
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2039.
Description
This pull request adds C
ndarrayimplementation forzscal.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers