Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench: refactor random number generation in stats/base/dists/betaprime #4840

Merged
merged 1 commit into from
Jan 21, 2025
Merged

bench: refactor random number generation in stats/base/dists/betaprime #4840

merged 1 commit into from
Jan 21, 2025

Conversation

anandkaranubc
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for stats/base/dists/betaprime.
  • Replaces randu() with uniform() for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
bench: move random number generation outside the benchmarking loops a…
ba8e6e5 
…nd use uniform instead of randu

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 21, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/cdf $\color{green}249/249$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}249/249$
$\color{green}+100.00\%$
stats/base/dists/betaprime/ctor $\color{green}419/419$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}419/419$
$\color{green}+100.00\%$
stats/base/dists/betaprime/kurtosis $\color{green}211/211$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}211/211$
$\color{green}+100.00\%$
stats/base/dists/betaprime/logcdf $\color{green}251/251$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}251/251$
$\color{green}+100.00\%$
stats/base/dists/betaprime/logpdf $\color{green}258/258$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}258/258$
$\color{green}+100.00\%$
stats/base/dists/betaprime/mean $\color{green}118/118$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}118/118$
$\color{green}+100.00\%$
stats/base/dists/betaprime/mode $\color{green}121/121$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}121/121$
$\color{green}+100.00\%$
stats/base/dists/betaprime/pdf $\color{green}237/237$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}237/237$
$\color{green}+100.00\%$
stats/base/dists/betaprime/quantile $\color{green}238/238$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}238/238$
$\color{green}+100.00\%$
stats/base/dists/betaprime/skewness $\color{green}207/207$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}207/207$
$\color{green}+100.00\%$
stats/base/dists/betaprime/stdev $\color{green}206/206$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}206/206$
$\color{green}+100.00\%$
stats/base/dists/betaprime/variance $\color{green}205/205$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}205/205$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

anandkaranubc commented Jan 21, 2025 •
edited
Loading

@kgryte, I'm working on a looooong pull request to refactor the rest of the stats/base/dists/* benchmarks. Apologies for the individual ones earlier; I realized I should have tackled them all together.

Any advice on your side?

@kgryte
Copy link
Member

kgryte commented Jan 21, 2025

Individual PRs are fine, as they are also easier to review.

@anandkaranubc
Copy link
Contributor Author

Individual PRs are fine, as they are also easier to review.

Ok perfect! This was the only reason I was creating individual ones. Will continue to do so then. Thanks!

@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Jan 21, 2025
kgryte
kgryte approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @anandkaranubc, for working on this!

@kgryte kgryte merged commit 68894a1 into stdlib-js:develop Jan 21, 2025
57 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 21, 2025
@anandkaranubc anandkaranubc deleted the betaprime-benchmarks branch January 21, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandkaranubc @stdlib-bot @kgryte