Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for stats/base/dists/geometric/mean #4089

Merged
merged 3 commits into from
Jan 8, 2025
Merged

feat: add C implementation for stats/base/dists/geometric/mean #4089

merged 3 commits into from
Jan 8, 2025

Conversation

0PrashantYadav0
Copy link
Contributor

Resolves #3635

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/geometric/mean along with relevant tests, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/mean $\color{green}165/165$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}165/165$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0 0PrashantYadav0 changed the title feat: add C implementation for stats/base/dists/geometric/mean feat: add C implementation for stats/base/dists/geometric/mean Dec 20, 2024
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
Planeshifter
Planeshifter requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments as in #4090 apply.

@0PrashantYadav0, would you be able to please update all your geometric/* PRs by making the requested changes? Thanks in advance!

@0PrashantYadav0
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot
Copy link
Contributor

@0PrashantYadav0, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@0PrashantYadav0
Copy link
Contributor Author

@Planeshifter Please review this as well as all the pr of geometric distributions.

@0PrashantYadav0
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 7, 2025
Planeshifter
Planeshifter approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in...

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/geometric/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4089
Closes: https://github.com/stdlib-js/stdlib/issues/3635

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 25c58d7 into stdlib-js:develop Jan 8, 2025
28 checks passed
0PrashantYadav0 added a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@0PrashantYadav0 @Planeshifter @stdlib-bot
feat: add C implementation for stats/base/dists/geometric/mean
e8cdf46 
PR-URL: stdlib-js#4089
Closes: stdlib-js#3635

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@0PrashantYadav0 @Planeshifter
@stdlib-bot @Neerajpathak07
feat: add C implementation for stats/base/dists/geometric/mean
d4ae1b6 
PR-URL: stdlib-js#4089
Closes: stdlib-js#3635

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@0PrashantYadav0 @Planeshifter
@stdlib-bot @ShabiShett07
feat: add C implementation for stats/base/dists/geometric/mean
86bf45d 
PR-URL: stdlib-js#4089
Closes: stdlib-js#3635

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/geometric/mean
3 participants
@0PrashantYadav0 @stdlib-bot @Planeshifter