feat: add C implementation for `stats/base/dists/levy/median` #4076

vivekmaurya001 · 2024-12-20T06:52:51Z

Resolves #3727.

Description

adds C implementation for @stdlib/stats/base/dists/levy/median along with relevant tests, benchmarks and examples

This pull request:

Progresses: [RFC]: Add C implementation for @stdlib/stats/base/dists/levy/median #3727

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

…into levy/median

stdlib-bot · 2024-12-20T06:55:05Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/levy/median	$\color{green}182/182$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}182/182$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter · 2025-01-19T20:46:35Z

/stdlib update-copyright-years

Planeshifter · 2025-01-19T21:14:52Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/src/main.c

+* // returns ~0.795
+*/
+double stdlib_base_dists_levy_median( const double mu, const double c ) {
+    double DENOM = 2.0 * stdlib_base_pow( stdlib_base_erfcinv( 0.5 ), 2.0 );


@vivekmaurya001 We should pre-compute this constant as a static const in the outer scope since erfcinv(0.5) is constant and doesn't change with the inputs.

i have tried it with static const but i was getting error in that so i have maded it static double , is it ok ?

Planeshifter · 2025-01-19T21:15:04Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/src/main.c

+#include "stdlib/math/base/special/pow.h"
+
+
+/**


Suggested change

#include "stdlib/math/base/special/pow.h"

/**

#include "stdlib/math/base/special/pow.h"

/**

Planeshifter · 2025-01-19T21:15:25Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/README.md

+
+#### stdlib_base_dists_levy_median( mu, c )
+
+Evaluates the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.


Suggested change

Evaluates the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.

Returns the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.

Planeshifter · 2025-01-19T21:15:41Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/README.md

+    int i;
+
+    for ( i = 0; i < 25; i++ ) {
+        mu = random_uniform( 0.0, 10.0 ) - 5.0;


Suggested change

mu = random_uniform( 0.0, 10.0 ) - 5.0;

mu = random_uniform( -5.0, 5.0 );

Planeshifter · 2025-01-19T21:16:30Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/examples/c/example.c

+	int i;
+
+	for ( i = 0; i < 25; i++ ) {
+		mu = random_uniform( 0.0, 10.0 ) - 5.0;


Suggested change

mu = random_uniform( 0.0, 10.0 ) - 5.0;

mu = random_uniform( -5.0, 5.0 );

Planeshifter · 2025-01-19T21:17:03Z

lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/c/benchmark.c

+		mu[ i ] = random_uniform( 0.0, 100.0 ) - 50.0;
+		c[ i ] = random_uniform( 0.0, 20.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;


Suggested change

mu[ i ] = random_uniform( 0.0, 100.0 ) - 50.0;

c[ i ] = random_uniform( 0.0, 20.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;

mu[ i ] = random_uniform( -50.0, 50.0 );

c[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 20.0 );

done , one thing to ask ,can we not take c as 0 or smaller than eps

Planeshifter

Left a comment on how to optimize the source implementation and pointed out a bunch of other small issues. Should be ready to land once these are addressed.

…into levy/median

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

vivekmaurya001 · 2025-01-21T12:40:18Z

@Planeshifter , done the changes please take a look

vivekmaurya001 added 2 commits December 20, 2024 11:37

feat(add c implementation): add stats/base/dists/levy/median

d873add

Merge branch 'levy/median' of https://github.com/vivekmaurya001/stdlib …

2d25eed

…into levy/median

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024

Merge branch 'stdlib-js:develop' into levy/median

b24a749

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025

chore: update copyright years

cc3ee1e

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025

Planeshifter reviewed Jan 19, 2025

View reviewed changes

Planeshifter requested changes Jan 19, 2025

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 19, 2025

vivekmaurya001 and others added 3 commits January 20, 2025 19:04

Merge branch 'levy/median' of https://github.com/vivekmaurya001/stdlib …

2969570

…into levy/median

Merge branch 'stdlib-js:develop' into levy/median

066d7de

Merge branch 'levy/median' of https://github.com/vivekmaurya001/stdlib …

1f291ed

…into levy/median

vivekmaurya001 marked this pull request as draft January 20, 2025 19:18

vivekmaurya001 added 6 commits January 20, 2025 19:18

feat(add c implementation): add stats/base/dists/levy/median

67320dd

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

feat(add c implementation): add stats/base/dists/levy/median

9f498ac

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

feat(add c implementation): add stats/base/dists/levy/median

0891b40

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

feat(add c implementation): add stats/base/dists/levy/median

4d766f0

feat(add c implementation): add stats/base/dists/levy/median

0e8064a

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

vivekmaurya001 marked this pull request as ready for review January 21, 2025 12:39

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add C implementation for `stats/base/dists/levy/median` #4076

feat: add C implementation for `stats/base/dists/levy/median` #4076

vivekmaurya001 commented Dec 20, 2024

stdlib-bot commented Dec 20, 2024 •

edited

Loading

Planeshifter commented Jan 19, 2025

Planeshifter Jan 19, 2025

vivekmaurya001 Jan 20, 2025

vivekmaurya001 Jan 21, 2025

Planeshifter Jan 19, 2025

Planeshifter Jan 19, 2025

vivekmaurya001 Jan 21, 2025

Planeshifter Jan 19, 2025

vivekmaurya001 Jan 21, 2025

Planeshifter Jan 19, 2025

vivekmaurya001 Jan 21, 2025

Planeshifter Jan 19, 2025

vivekmaurya001 Jan 21, 2025

Planeshifter left a comment

vivekmaurya001 commented Jan 21, 2025


		#### stdlib_base_dists_levy_median( mu, c )

		Evaluates the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.

	Evaluates the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.
	Returns the [median][median] for a [Lévy][levy-distribution] distribution with location parameter `mu` and scale parameter `c`.

	mu = random_uniform( 0.0, 10.0 ) - 5.0;
	mu = random_uniform( -5.0, 5.0 );

		mu[ i ] = random_uniform( 0.0, 100.0 ) - 50.0;
		c[ i ] = random_uniform( 0.0, 20.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;

feat: add C implementation for stats/base/dists/levy/median #4076

Are you sure you want to change the base?

feat: add C implementation for stats/base/dists/levy/median #4076

Conversation

vivekmaurya001 commented Dec 20, 2024

Description

Questions

Other

Checklist

stdlib-bot commented Dec 20, 2024 • edited Loading

Coverage Report

Planeshifter commented Jan 19, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Planeshifter left a comment

Choose a reason for hiding this comment

vivekmaurya001 commented Jan 21, 2025

feat: add C implementation for `stats/base/dists/levy/median` #4076

feat: add C implementation for `stats/base/dists/levy/median` #4076

stdlib-bot commented Dec 20, 2024 •

edited

Loading