Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for stats/base/dists/betaprime/pdf #4057

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

feat: add C implementation for stats/base/dists/betaprime/pdf #4057

wants to merge 7 commits into from

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3443.

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/betaprime/pdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 19, 2024
@Planeshifter Planeshifter added bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Lint Autofix Pull request needing applicable lint errors to be automatically fixed. labels Dec 20, 2024
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Dec 20, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 14:57
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
Neerajpathak07
Neerajpathak07 commented Feb 8, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/betaprime/pdf/src/main.c
return 0.0 / 0.0; //NaN
}

return stdlib_base_exp( stdlib_base_dists_betaprime_logpdf( x, alpha, beta ) );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be on hold till we have the implementation for betaprime/logpdf which is #4059.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @Planeshifter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/pdf
3 participants
@Neerajpathak07 @Planeshifter @stdlib-bot