-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for stats/base/dists/uniform/mean
#3964
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Left a bunch of comments we should address.
I believe the slash commands didn't work for you because any workflows for new contributors have to initially be approved. I will look into us making this clearer...
@Planeshifter Make all the changes. Please review all the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Made a bunch of fixes, but should be ready for landing soon.
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/src/main.c
Outdated
Show resolved
Hide resolved
...modules/@stdlib/stats/base/dists/uniform/mean/include/stdlib/stats/base/dists/uniform/mean.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/lib/native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
lib/node_modules/@stdlib/stats/base/dists/uniform/mean/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#3964 Closes: stdlib-js#3830 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#3964 Closes: stdlib-js#3830 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
Resolves #3830
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/uniform/mean
#3830Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers