Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/sqrt-phi #3351

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 6, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 6, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 6, 2024

Coverage Report

Package Statements Branches Functions Lines
constants/float32/sqrt-phi $\color{green}49/49$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}49/49$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024

PR Commit Message

feat: add constants/float32/sqrt-phi

PR-URL: https://github.com/stdlib-js/stdlib/pull/3351

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter changed the title feat: add constants/float32/sqrt-phi feat: add constants/float32/sqrt-phi Dec 7, 2024
@Planeshifter Planeshifter merged commit fdee038 into stdlib-js:develop Dec 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants