feat: add math/base/special/lucasf

[aayush0325]

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

• adds math/base/special/lucasf

Related Issues

Does this pull request have any related issues?

This pull request:

• Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This branch can further be rebased to include constants/float32/max-safe-nth-lucas macro from #3337 instead of using just 34 as it is.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

@aayush0325, available slash commands include:

• /stdlib check-files - Check for required files.
• /stdlib update-copyright-years - Update copyright header years.
• /stdlib lint-autofix - Auto-fix lint errors.
• /stdlib merge - Merge changes from develop branch into this PR.
• /stdlib rebase - Rebase this PR on top of develop branch.

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/lucasf	$\color{green}224/224$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}224/224$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[aayush0325]

/stdlib update-copyright-years

[stdlib-bot]

@aayush0325, slash command not recognized. Please use /stdlib help to view available commands.

[aayush0325]

/stdlib update-copyright-years

[gunjjoshi]

@aayush0325 Thanks for working on this. Can you please update both JS and C benchmarks to pre-compute the values, outside the loop?

[aayush0325]

got it, pushing soon.

[aayush0325]

pushed

[aayush0325]

/stdlib merge

[aayush0325]

good afternoon @gunjjoshi. I've pushed the requested changes. However a linting error was stopping me from updating the description in lib/index.js to "Compute/Computes the nth Lucas number as a single-precision floating-point number." Please let me know how to proceed here.

[gunjjoshi]

@aayush0325 You don't have to use Compute/Computes everywhere. What I was trying to say was,
For files such as index.js, package.json, etc. we should use:

Compute the nth Lucas number as a single-precision floating-point number.

while, for the rest files, we should use:

Computes the nth Lucas number as a single-precision floating-point number.

[aayush0325]

Ah, my bad. pushing the needed changes soon.

[aayush0325]

Pushed, sorry for the misunderstanding.

[aayush0325]

I don't get why this is failing the linting tests this seems to run fine locally on the dev container @gunjjoshi

[aayush0325]

/stdlib merge

[kgryte]

/stdlib merge

[kgryte]

/stdlib merge

[gunjjoshi]

Although we have used STDLIB_MATH_BASE_NAPI_MODULE_I_D in math/base/special/lucas, we can use STDLIB_MATH_BASE_NAPI_MODULE_I_I here and modify the function signature accordingly, as we have the API ready which accepts and returns an int32 value, but we don't have an API to accept int32 and return an int64 value, as in the case of lucas.

[gunjjoshi]

cc: @kgryte @Planeshifter

[kgryte]

@aayush0325 Did you mean to delete the lucasf branch?

[aayush0325]

@aayush0325 Did you mean to delete the lucasf branch?

was getting rid of the merged branches, this was a mistake 😅