Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the fixer function to eslint/rules/no-empty-comments #3340

Merged
merged 3 commits into from
Dec 7, 2024
Merged

feat: add the fixer function to eslint/rules/no-empty-comments #3340

merged 3 commits into from
Dec 7, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add the fixer function the rule to allow auto-fixing.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2024
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Dec 5, 2024
@Planeshifter Planeshifter self-requested a review December 7, 2024 21:52
Planeshifter
Planeshifter approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @headlessNode! Great to have more fixers for our ESLint rules. 🚀

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add the `fixer` function to `eslint/rules/no-empty-comments`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3340

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b47ab4f into stdlib-js:develop Dec 7, 2024
16 checks passed
@headlessNode headlessNode deleted the lint-empty-comments branch December 8, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @Planeshifter