-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float32/sqrt-three
#3322
feat: add constants/float32/sqrt-three
#3322
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
constants/float32/sqrt-three
lib/node_modules/@stdlib/constants/float32/sqrt-three/package.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/test/test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, which is much appreciated! Left two small comments; overall looks good and your PR should be ready to land.
lib/node_modules/@stdlib/constants/float32/sqrt-three/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/README.md
Outdated
Show resolved
Hide resolved
...e_modules/@stdlib/constants/float32/sqrt-three/include/stdlib/constants/float64/sqrt_three.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/package.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/package.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/sqrt-three/README.md
Outdated
Show resolved
Hide resolved
/stdlib lint-autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another review pass; should be ready to land. Thank you!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers