Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/sqrt-three #3322

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 4, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

None

This pull request:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 4, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 4, 2024

Coverage Report

Package Statements Branches Functions Lines
constants/float32/sqrt-three $\color{green}51/51$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}51/51$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@manvith2003 manvith2003 changed the title Float32 sqrt three feat :add constants/float32/sqrt-three Dec 4, 2024
@gunjjoshi gunjjoshi changed the title feat :add constants/float32/sqrt-three feat: add constants/float32/sqrt-three Dec 4, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, which is much appreciated! Left two small comments; overall looks good and your PR should be ready to land.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 4, 2024
@Planeshifter
Copy link
Member

/stdlib lint-autofix

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Dec 7, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another review pass; should be ready to land. Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024

PR Commit Message

feat: add `constants/float32/sqrt-three`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3322

Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 935a1af into stdlib-js:develop Dec 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants