Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the return type and remove unnecessary branches/tests in blas/ext/base/ssumpw #3321

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: update the return type and remove unnecessary branches/tests in blas/ext/base/ssumpw #3321

merged 2 commits into from
Dec 4, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • update the return type of the blas/ext/base/ssumpw
  • remove redundant branches and related test cases

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 3, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 3, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ssumpw $\color{green}435/435$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}435/435$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

kgryte
kgryte reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode Left one last question. Once resolved, this should be ready for merge.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 3, 2024
@headlessNode
Copy link
Member Author

@kgryte done.

kgryte
kgryte approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte changed the title fix: update the return type and remove redundant branches/tests in blas/ext/base/ssumpw fix: update the return type and remove unnecessary branches/tests in blas/ext/base/ssumpw Dec 4, 2024
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 4, 2024
@kgryte kgryte merged commit fcedaac into stdlib-js:develop Dec 4, 2024
13 checks passed
nate10j pushed a commit to nate10j/stdlib that referenced this pull request Dec 7, 2024
@headlessNode @nate10j
fix: update the return type and remove unnecessary branches/tests in …
5429088 
…`blas/ext/base/ssumpw`

PR-URL: stdlib-js#3321
Reviewed-by: Athan Reines <[email protected]>
@headlessNode headlessNode deleted the ssumpw-refactor branch December 8, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @kgryte