refactor: use constants/float64/max-ln in math/base/special/riemann-zeta

[gunjjoshi]

Description

What is the purpose of this pull request?

This pull request:

• completes the TODO to use external constant from constants/float64/max-ln in math/base/special/riemann-zeta.
• updates the argument name in the header file to match with what we have used in the C implementation.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/riemann-zeta	$\color{red}889/915$ $\color{green}+97.16\%$	$\color{red}68/82$ $\color{green}+82.93\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{red}889/915$ $\color{green}+97.16\%$

The above coverage report was generated for the changes in this PR.

[gunjjoshi]

The CI failure seems to be coming from the constant being initialized at runtime. Should we revert back to declaring

static const double MAX_LN = 709.0;

for the C implementation, while keeping the use of external package only for the JS implementation?

[kgryte]

The CI failure seems to be coming from the constant being initialized at runtime.

Ah, right. Yes, let's go ahead and in-line the constant value to 709.0.

[kgryte]

LGTM. Thanks, @gunjjoshi!