-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/assert/is-oddf
#3316
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
@aayush0325 We should pre-compute the values for the C and JS benchmarks, as we do here: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/assert/is-evenf/benchmark |
@aayush0325 You can follow what we've done in https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/assert/is-evenf/src/addon.c. We've used available macros to avoid writing the whole logic again. |
thanks for reviewing @gunjjoshi ! i've pushed the requested changes. |
Signed-off-by: Gunj Joshi <[email protected]>
lib/node_modules/@stdlib/math/base/assert/is-oddf/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Apart from one change to update JS examples, everything else looks good to me. |
Signed-off-by: Gunj Joshi <[email protected]>
Looks like this PR is a duplicate of #3125. @gunjjoshi Would you mind checking which PR we should proceed with? |
my apologies, closing this. |
Resolves #3313
Description
This pull request:
math/base/assert/is-oddf
Related Issues
This pull request:
math/base/assert/is-oddf
#3313Questions
There wasn't a macro for the addon of this particular function so I've just explicitly type-casted the double value to a float, is that correct? (please see
src/addon.c
)Other
No.
Checklist
@stdlib-js/reviewers