Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add findLast method to array/fixed-endian-factory #3312

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: add findLast method to array/fixed-endian-factory #3312

wants to merge 11 commits into from

Conversation

ahmad-kashkoush
Copy link
Contributor

Resolves #3143.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1165/1416$
$\color{green}+82.27\%$ 		$\color{red}149/161$
$\color{green}+92.55\%$ 		$\color{red}23/33$
$\color{green}+69.70\%$ 		$\color{red}1165/1416$
$\color{green}+82.27\%$

The above coverage report was generated for the changes in this PR.

@ahmad-kashkoush
Copy link
Contributor Author

ahmad-kashkoush commented Dec 1, 2024 •
edited
Loading

Good evening, @kgryte may you give this a review

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 3, 2024
kgryte
kgryte reviewed Dec 3, 2024
View reviewed changes
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.find_last.js Outdated

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
out = arr.every( predicate );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect method name.

kgryte
kgryte requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @ahmad-kashkoush. Left some comments. If you could also resolve the merge conflicts, that would be appreciated. Cheers!

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 3, 2024
ahmad-kashkoush and others added 8 commits December 4, 2024 11:00
@ahmad-kashkoush @kgryte
docs: update Readme
2990ae0 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush @kgryte
docs: update Readme
16ba578 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush @kgryte
docs: update Readme
be75be4 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush @kgryte
docs: update Readme
f30faa8 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush @kgryte
docs: update Readme
0549144 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush @kgryte
refactor: update benchmark predicate function
e5b01b1 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush
fix: correct benchmark method name
e8f9e7c
@ahmad-kashkoush
Merge branch 'develop' into feat/fixed-endian-findLast
d6b5968 
Signed-off-by: Ahmed_Kashkoush <[email protected]>
@ahmad-kashkoush
Copy link
Contributor Author

Thanks for working on this, @ahmad-kashkoush. Left some comments. If you could also resolve the merge conflicts, that would be appreciated. Cheers!

Thanks, I 've made changes and resolved the conflict, give it another review please

@ahmad-kashkoush
Copy link
Contributor Author

@kgryte May you give it a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add findLast method to array/fixed-endian-factory
3 participants
@ahmad-kashkoush @stdlib-bot @kgryte