Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keys method to array/fixed-endian-factory #3310

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ahmad-kashkoush
Copy link
Contributor

Resolves #3148.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@ahmad-kashkoush ahmad-kashkoush changed the title feat: add method method to array/fixed-endian-factory feat: add keys method to array/fixed-endian-factory Dec 1, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Dec 1, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1218/1469$
$\color{green}+82.91\%$
$\color{red}153/165$
$\color{green}+92.73\%$
$\color{red}26/36$
$\color{green}+72.22\%$
$\color{red}1218/1469$
$\color{green}+82.91\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title feat: add keys method to array/fixed-endian-factory feat: add keys method to array/fixed-endian-factory Dec 3, 2024
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 3, 2024
@ahmad-kashkoush
Copy link
Contributor Author

@kgryte I have resolved conflicts, as well as put keys method into its correct order in both readme and main.js, may you give it a review?

@ahmad-kashkoush
Copy link
Contributor Author

@kgryte @Planeshifter May you give it a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add keys method to array/fixed-endian-factory
4 participants