-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toReversed
method to array/fixed-endian-factory
#3299
Open
nate10j
wants to merge
19
commits into
stdlib-js:develop
Choose a base branch
from
nate10j:feature/fixed-endian-factory-toReverse
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1c707c5
fix: resolve merge conflicts
nate10j 9be5f9e
test: add tests for toReverse method in array/fixed-endian-factory
nate10j f5b6712
bench: add benchmarks for toReverse method in array/fixed-endian-factory
nate10j 04f6f81
docs: add documentation for toReverse method in array/fixed-endian-fa…
nate10j b4eeca2
fix: add missing test to toReverse method in array/fixed-endian-factory
nate10j 459d8f4
style: add missing space to array/fixed-endian-factory/benchmark
nate10j 361340c
fix: capitalise fail message in array/fixed-endian-factory/benchmark
nate10j a43f648
refactor: edit arr variable declaration in array/fixed-endian-factory…
nate10j 4d1c5ce
fix: edit fail message in array/fixed-endian-factory/benchmark
nate10j f770a9c
docs: update JSDoc comment toReversed method in array/fixed-endian-fa…
nate10j 6d03899
docs: edit JSDoc comment to toReversed method in array/fixed-endian-f…
nate10j c701482
docs: edit JSDoc comment to toReversed method in array/fixed-endian-f…
nate10j fe317dd
perf: minimize arithmetic in array/fixed-endian-factory
nate10j 661d0bc
style: add missing space to array/fixed-endian-factory/test
nate10j 7f4f8be
style: remove blank line for toReversed method in array/fixed-endian-…
nate10j b595cc2
style: remove blank line for toReversed method in array/fixed-endian-…
nate10j da97081
docs: remove duplicate JSDoc comment in array/fixed-endian-factory
nate10j 328ba9d
test: use hasSameValues method to test in array/fixed-endian-factory
nate10j 0e0154c
style: insert toReversed in alphabetic order in array/fixed-endian-fa…
nate10j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.to_reversed.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var pkg = require( './../package.json' ).name; | ||
var factory = require( './../lib' ); | ||
|
||
|
||
// VARIABLES // | ||
|
||
var Float64ArrayFE = factory( 'float64' ); | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg+':toReversed', function benchmark( b ) { | ||
var out; | ||
var arr; | ||
var i; | ||
|
||
arr = new Float64ArrayFE( 'little-endian', [ 1.0, 2.0, 2.0, 1.0 ] ); | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
out = arr.toReversed(); | ||
if ( typeof out !== 'object' ) { | ||
b.fail( 'should return an object' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( !( out instanceof Float64ArrayFE ) ) { | ||
b.fail( 'should return a typed array' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
99 changes: 99 additions & 0 deletions
99
...node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.to_reversed.length.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var zeroTo = require( '@stdlib/array/zero-to' ); | ||
var pow = require( '@stdlib/math/base/special/pow' ); | ||
var pkg = require( './../package.json' ).name; | ||
var factory = require( './../lib' ); | ||
|
||
|
||
// VARIABLES // | ||
|
||
var Float64ArrayFE = factory( 'float64' ); | ||
|
||
|
||
// FUNCTIONS // | ||
|
||
/** | ||
* Creates a benchmark function. | ||
* | ||
* @private | ||
* @param {PositiveInteger} len - array length | ||
* @returns {Function} benchmark function | ||
*/ | ||
function createBenchmark( len ) { | ||
var arr = new Float64ArrayFE( 'little-endian', zeroTo( len ) ); | ||
return benchmark; | ||
|
||
/** | ||
* Benchmark function. | ||
* | ||
* @private | ||
* @param {Benchmark} b - benchmark instance | ||
*/ | ||
function benchmark( b ) { | ||
var out; | ||
var i; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
out = arr.toReversed(); | ||
if ( typeof out !== 'object' ) { | ||
b.fail( 'should return an object' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( !( out instanceof Float64ArrayFE ) ) { | ||
b.fail( 'should return a typed array' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
} | ||
} | ||
|
||
|
||
// MAIN // | ||
|
||
/** | ||
* Main execution sequence. | ||
* | ||
* @private | ||
*/ | ||
function main() { | ||
var len; | ||
var min; | ||
var max; | ||
var f; | ||
var i; | ||
|
||
min = 1; // 10^min | ||
max = 6; // 10^max | ||
|
||
for ( i = min; i <= max; i++ ) { | ||
len = pow( 10, i ); | ||
f = createBenchmark( len ); | ||
bench( pkg+':toReversed:len='+len, f ); | ||
} | ||
} | ||
|
||
main(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.to_reversed.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var tape = require( 'tape' ); | ||
var hasOwnProp = require( '@stdlib/assert/has-own-property' ); | ||
var isFunction = require( '@stdlib/assert/is-function' ); | ||
var instanceOf = require( '@stdlib/assert/instance-of' ); | ||
var hasSameValues = require( '@stdlib/array/base/assert/has-same-values' ); | ||
var factory = require( './../lib' ); | ||
|
||
|
||
// TESTS // | ||
|
||
tape( 'main export is a function', function test( t ) { | ||
t.ok( true, __filename ); | ||
t.strictEqual( typeof factory, 'function', 'main export is a function' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'attached to the prototype of the main export is a `toReversed` method', function test( t ) { | ||
var ctor = factory( 'float64' ); | ||
t.strictEqual( hasOwnProp( ctor.prototype, 'toReversed' ), true, 'returns expected value' ); | ||
t.strictEqual( isFunction( ctor.prototype.toReversed ), true, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method throws an error if invoked with a `this` context which is not a typed array instance', function test( t ) { | ||
var values; | ||
var ctor; | ||
var arr; | ||
var i; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', 5 ); | ||
|
||
values = [ | ||
'5', | ||
5, | ||
NaN, | ||
true, | ||
false, | ||
null, | ||
void 0, | ||
{}, | ||
[], | ||
function noop() {} | ||
]; | ||
for ( i = 0; i < values.length; i++ ) { | ||
t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); | ||
} | ||
|
||
function badValue( value ) { | ||
return function badValue() { | ||
return arr.toReversed.call( value ); | ||
}; | ||
} | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method returns an empty array if operating on an empty typed array', function test( t ) { | ||
var ctor; | ||
var arr; | ||
var out; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian' ); | ||
out = arr.toReversed(); | ||
|
||
t.strictEqual(out.length, 0, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method returns a new typed array containing elements in reverse order', function test( t ) { | ||
var expected; | ||
var ctor; | ||
var arr; | ||
var out; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0 ] ); | ||
expected = new ctor( 'little-endian', [ 4.0, 3.0, 2.0, 1.0 ] ); | ||
out = arr.toReversed(); | ||
|
||
t.strictEqual( instanceOf( out, ctor ), true, 'returns expected value' ); | ||
t.notEqual( out, arr, 'returns a new instance' ); | ||
t.strictEqual( hasSameValues( out, expected ), true, 'returns expected value' ); | ||
t.strictEqual( out.length, expected.length, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method does not change the array length', function test( t ) { | ||
var ctor; | ||
var arr; | ||
var out; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', 10 ); | ||
out = arr.toReversed(); | ||
|
||
t.strictEqual( out.length, 10, 'returns expected value' ); | ||
t.end(); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test doesn't compare values of
expected
against values ofout
, it just compares the length.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made changes