Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toReversed method to array/fixed-endian-factory #3299

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1c707c5
fix: resolve merge conflicts
nate10j Dec 1, 2024
9be5f9e
test: add tests for toReverse method in array/fixed-endian-factory
nate10j Nov 29, 2024
f5b6712
bench: add benchmarks for toReverse method in array/fixed-endian-factory
nate10j Nov 29, 2024
04f6f81
docs: add documentation for toReverse method in array/fixed-endian-fa…
nate10j Nov 29, 2024
b4eeca2
fix: add missing test to toReverse method in array/fixed-endian-factory
nate10j Dec 1, 2024
459d8f4
style: add missing space to array/fixed-endian-factory/benchmark
nate10j Dec 6, 2024
361340c
fix: capitalise fail message in array/fixed-endian-factory/benchmark
nate10j Dec 6, 2024
a43f648
refactor: edit arr variable declaration in array/fixed-endian-factory…
nate10j Dec 6, 2024
4d1c5ce
fix: edit fail message in array/fixed-endian-factory/benchmark
nate10j Dec 6, 2024
f770a9c
docs: update JSDoc comment toReversed method in array/fixed-endian-fa…
nate10j Dec 6, 2024
6d03899
docs: edit JSDoc comment to toReversed method in array/fixed-endian-f…
nate10j Dec 6, 2024
c701482
docs: edit JSDoc comment to toReversed method in array/fixed-endian-f…
nate10j Dec 6, 2024
fe317dd
perf: minimize arithmetic in array/fixed-endian-factory
nate10j Dec 6, 2024
661d0bc
style: add missing space to array/fixed-endian-factory/test
nate10j Dec 6, 2024
7f4f8be
style: remove blank line for toReversed method in array/fixed-endian-…
nate10j Dec 7, 2024
b595cc2
style: remove blank line for toReversed method in array/fixed-endian-…
nate10j Dec 7, 2024
da97081
docs: remove duplicate JSDoc comment in array/fixed-endian-factory
nate10j Dec 7, 2024
328ba9d
test: use hasSameValues method to test in array/fixed-endian-factory
nate10j Dec 7, 2024
0e0154c
style: insert toReversed in alphabetic order in array/fixed-endian-fa…
nate10j Dec 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/node_modules/@stdlib/array/fixed-endian-factory/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,31 @@ var count = context.count;
// returns 3
```

<a name="method-to-reversed"></a>

#### TypedArray.prototype.toReversed()

Returns a new typed array containing the elements in reversed order.

```javascript
var Float64ArrayFE = fixedEndianFactory( 'float64' );

var arr = new Float64ArrayFE( 'little-endian', [ 1.0, 2.0, 3.0 ] );
// returns <Float64ArrayFE>

var out = arr.toReversed();
// returns <Float64ArrayFE>

var v = out.get( 0 );
// returns 3.0

v = out.get( 1 );
// returns 2.0

v = out.get( 2 );
// returns 1.0
```

<a name="method-to-string"></a>

#### TypedArrayFE.prototype.toString()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2024 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var bench = require( '@stdlib/bench' );
var pkg = require( './../package.json' ).name;
var factory = require( './../lib' );


// VARIABLES //

var Float64ArrayFE = factory( 'float64' );


// MAIN //

bench( pkg+':toReversed', function benchmark( b ) {
var out;
var arr;
var i;

arr = new Float64ArrayFE( 'little-endian', [ 1.0, 2.0, 2.0, 1.0 ] );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
out = arr.toReversed();
if ( typeof out !== 'object' ) {
b.fail( 'should return an object' );
}
}
b.toc();
if ( !( out instanceof Float64ArrayFE ) ) {
b.fail( 'should return a typed array' );
}
b.pass( 'benchmark finished' );
b.end();
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2024 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var bench = require( '@stdlib/bench' );
var zeroTo = require( '@stdlib/array/zero-to' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
var factory = require( './../lib' );


// VARIABLES //

var Float64ArrayFE = factory( 'float64' );


// FUNCTIONS //

/**
* Creates a benchmark function.
*
* @private
* @param {PositiveInteger} len - array length
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var arr = new Float64ArrayFE( 'little-endian', zeroTo( len ) );
return benchmark;

/**
* Benchmark function.
*
* @private
* @param {Benchmark} b - benchmark instance
*/
function benchmark( b ) {
var out;
var i;

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
out = arr.toReversed();
if ( typeof out !== 'object' ) {
b.fail( 'should return an object' );
}
}
b.toc();
if ( !( out instanceof Float64ArrayFE ) ) {
b.fail( 'should return a typed array' );
}
b.pass( 'benchmark finished' );
b.end();
}
}


// MAIN //

/**
* Main execution sequence.
*
* @private
*/
function main() {
var len;
var min;
var max;
var f;
var i;

min = 1; // 10^min
max = 6; // 10^max

for ( i = min; i <= max; i++ ) {
len = pow( 10, i );
f = createBenchmark( len );
bench( pkg+':toReversed:len='+len, f );
}
}

main();
32 changes: 32 additions & 0 deletions lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -1089,6 +1089,38 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli
return false;
});

/**
* Returns a new typed array containing the elements in reversed order.
*
* @private
* @name toReversed
* @memberof TypedArray.prototype
* @type {Function}
* @throws {TypeError} `this` is not a typed array
* @returns {TypedArray} reversed array
*/
setReadOnly( TypedArray.prototype, 'toReversed', function toReversed() {
var obuf;
var out;
var len;
var buf;
var i;
var v;

if ( !isTypedArray( this ) ) {
throw new TypeError( 'invalid invocation. `this` is not a typed array.' );
}
len = this._length;
out = new this.constructor( flag2byteOrder( this._isLE ), len );
buf = this._buffer;
obuf = out._buffer; // eslint-disable-line no-underscore-dangle
for ( i = 0; i < len; i++ ) {
v = buf[ GETTER ]( ( len - i - 1 ) * BYTES_PER_ELEMENT, this._isLE );
obuf[ SETTER ]( i * BYTES_PER_ELEMENT, v, this._isLE );
}
return out;
});

/**
* Serializes an array as a string.
*
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2024 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var tape = require( 'tape' );
var hasOwnProp = require( '@stdlib/assert/has-own-property' );
var isFunction = require( '@stdlib/assert/is-function' );
var instanceOf = require( '@stdlib/assert/instance-of' );
var hasSameValues = require( '@stdlib/array/base/assert/has-same-values' );
var factory = require( './../lib' );


// TESTS //

tape( 'main export is a function', function test( t ) {
t.ok( true, __filename );
t.strictEqual( typeof factory, 'function', 'main export is a function' );
t.end();
});

tape( 'attached to the prototype of the main export is a `toReversed` method', function test( t ) {
var ctor = factory( 'float64' );
t.strictEqual( hasOwnProp( ctor.prototype, 'toReversed' ), true, 'returns expected value' );
t.strictEqual( isFunction( ctor.prototype.toReversed ), true, 'returns expected value' );
t.end();
});

tape( 'the method throws an error if invoked with a `this` context which is not a typed array instance', function test( t ) {
var values;
var ctor;
var arr;
var i;

ctor = factory( 'float64' );
arr = new ctor( 'little-endian', 5 );

values = [
'5',
5,
NaN,
true,
false,
null,
void 0,
{},
[],
function noop() {}
];
for ( i = 0; i < values.length; i++ ) {
t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] );
}

function badValue( value ) {
return function badValue() {
return arr.toReversed.call( value );
};
}
t.end();
});

tape( 'the method returns an empty array if operating on an empty typed array', function test( t ) {
var ctor;
var arr;
var out;

ctor = factory( 'float64' );
arr = new ctor( 'little-endian' );
out = arr.toReversed();

t.strictEqual(out.length, 0, 'returns expected value' );
t.end();
});

tape( 'the method returns a new typed array containing elements in reverse order', function test( t ) {
var expected;
var ctor;
var arr;
var out;

ctor = factory( 'float64' );
arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0 ] );
expected = new ctor( 'little-endian', [ 4.0, 3.0, 2.0, 1.0 ] );
out = arr.toReversed();

t.strictEqual( instanceOf( out, ctor ), true, 'returns expected value' );
t.notEqual( out, arr, 'returns a new instance' );
t.strictEqual( hasSameValues( out, expected ), true, 'returns expected value' );
t.strictEqual( out.length, expected.length, 'returns expected value' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test doesn't compare values of expected against values of out, it just compares the length.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes

t.end();
});

tape( 'the method does not change the array length', function test( t ) {
var ctor;
var arr;
var out;

ctor = factory( 'float64' );
arr = new ctor( 'little-endian', 10 );
out = arr.toReversed();

t.strictEqual( out.length, 10, 'returns expected value' );
t.end();
});
Loading