Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter method to array/fixed-endian-factory #3278

Merged
merged 6 commits into from
Dec 1, 2024

Conversation

aayush0325
Copy link
Member

Resolves #3140

Description

What is the purpose of this pull request?

This pull request:

  • adds filter method to array/fixed-endian-factory
  • adds relevant tests and benchmarks
  • updates README with examples and documentation

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 27, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}883/1140$
$\color{green}+77.46\%$
$\color{red}70/79$
$\color{green}+88.61\%$
$\color{red}15/26$
$\color{green}+57.69\%$
$\color{red}883/1140$
$\color{green}+77.46\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

greetings! kindly give this a review @kgryte .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 1, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aayush0325 for your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024

PR Commit Message

feat: add `filter` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3278
Closes: https://github.com/stdlib-js/stdlib/issues/3140

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1242bbf into stdlib-js:develop Dec 1, 2024
18 checks passed
@aayush0325 aayush0325 deleted the filter branch February 16, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add filter method to array/fixed-endian-factory
3 participants