Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dsnansumpw #3262

Merged
merged 5 commits into from
Nov 26, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dsnansumpw #3262

merged 5 commits into from
Nov 26, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor/cleanup blas/ext/base/dsnansumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 25, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 25, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsnansumpw $\color{green}457/457$
$\color{green}+100.00\%$ 		$\color{green}59/59$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}457/457$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Nov 25, 2024
@headlessNode
Copy link
Member Author

Test failure from a downstream package.

@headlessNode headlessNode marked this pull request as ready for review November 25, 2024 13:51
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 26, 2024
@headlessNode
Copy link
Member Author

@kgryte Changes applied.

@headlessNode @Planeshifter
chore: apply review suggestions
faa100b 
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>
Planeshifter
Planeshifter approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Nov 26, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/dsnansumpw`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3262

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit de75f04 into stdlib-js:develop Nov 26, 2024
18 of 19 checks passed
@headlessNode headlessNode deleted the dsnansumpw-refactor branch December 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@headlessNode @stdlib-bot @Planeshifter @kgryte