Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array/base/braodcasted-ternary3d #3228

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

@Vinit-Pandit Vinit-Pandit commented Nov 23, 2024

Resolves #3164

Description

What is the purpose of this pull request?

This pull request:

  • adding implementation of array/base/braodcasted-ternary3d

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 23, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/broadcasted-ternary3d $\color{green}223/223$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}223/223$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Contributor

Neerajpathak07 commented Nov 23, 2024

Pls use a backtick while naming packages.
Ex:- array/base/broadcasted-ternary3d

@Vinit-Pandit
Copy link
Contributor Author

Vinit-Pandit commented Nov 23, 2024

Pls use a backtick while naming packages. Ex:- array/base/broadcasted-ternary3d

Can u please point me out @Neerajpathak07 ?

@Neerajpathak07
Copy link
Contributor

Sure whenever you are naming files or packages in the PR title or description write it in this way:-
image

@Vinit-Pandit Vinit-Pandit changed the title feat: add array/base/braodcasted-ternary3d feat: add array/base/braodcasted-ternary3d Nov 23, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 24, 2024
@kgryte
Copy link
Member

kgryte commented Nov 25, 2024

@MeastroZI This PR has varying space conventions. Please update to ensure that there are spaces inside brackets and parens (e.g., ( t ) and [ 1, 2, 3 ] and [ i4 ]). The dominant convention in this project is to include spaces, and we expect all PRs to follow those conventions. This likely also applies to your other open PRs.

@Vinit-Pandit
Copy link
Contributor Author

@stdlib-js/reviewers

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @MeastroZI.

For reference, I made various clean-up changes in 438efb9. I recommend checking that commit to determine if similar changes should be applied to your other open PRs.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 25, 2024
@kgryte kgryte merged commit fb3c880 into stdlib-js:develop Nov 25, 2024
12 checks passed
@Vinit-Pandit
Copy link
Contributor Author

This small things are really hard to catch, for me atleast 🥲🤧 ,
Thank you @kgryte i will take a close look on this commit !

LGTM. Thanks for working on this, @MeastroZI.

For reference, I made various clean-up changes in ### ### 438efb9. I recommend checking that commit to determine if similar changes should be applied to your other open PRs.

pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
PR-URL: stdlib-js#3228
Closes: stdlib-js#3164
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@Vinit-Pandit Vinit-Pandit deleted the broadcasted-ternary3d branch November 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/broadcasted-ternary3d
4 participants