-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add array/base/braodcasted-ternary3d
#3228
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Pls use a backtick while naming packages. |
Can u please point me out @Neerajpathak07 ? |
array/base/braodcasted-ternary3d
@MeastroZI This PR has varying space conventions. Please update to ensure that there are spaces inside brackets and parens (e.g., |
a74f643
to
c674c46
Compare
@stdlib-js/reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this, @MeastroZI.
For reference, I made various clean-up changes in 438efb9. I recommend checking that commit to determine if similar changes should be applied to your other open PRs.
This small things are really hard to catch, for me atleast 🥲🤧 ,
|
PR-URL: stdlib-js#3228 Closes: stdlib-js#3164 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
Resolves #3164
Description
This pull request:
array/base/braodcasted-ternary3d
Related Issues
This pull request:
array/base/broadcasted-ternary3d
#3164Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers