refactor: update math/base/special/atanh according to the FreeBSD implementation
#3128
+12
−12
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,15 +82,15 @@ double stdlib_base_atanh( const double x ) { | |
| int32_t sgn; | ||
| double ax; | ||
| double t; | ||
|
|
||
| if( ax > 1 || stdlib_base_is_nan( x ) ) { // |x|>1 or x is NaN | ||
| return 0.0 / 0.0 ; //NaN | ||
| } | ||
|
|
||
| if( ax == 1 ) { // |x| == 1 | ||
| return (sgn > 0) ? STDLIB_CONSTANT_FLOAT64_NINF : STDLIB_CONSTANT_FLOAT64_PINF; | ||
| } | ||
|
|
||
|
Comment on lines
+85
to
+93
There was a problem hiding this comment. @RiyaChy072 This isn't what we need to do here. As mentioned previously, we need to use various stdlib utilities here, similar to how they are being used in the FreeBSD reference implementation. There was a problem hiding this comment. @gunjjoshi Can i use HIGH_WORD_ABS_MASK here? |
||
| if ( x < 0.0 ) { | ||
| sgn = 1; | ||
| ax = -x; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RiyaChy072 I don't think we need to change these fixtures for this. Was there any specific reason to update them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gunjjoshi I thought that needed to be done, didn't know we don't need that