Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/sqrtpif #3116

Merged
merged 10 commits into from
Dec 15, 2024
Merged

Conversation

gururaj1512
Copy link
Member

@gururaj1512 gururaj1512 commented Nov 15, 2024

Resolves a part of #649 .

Description

What is the purpose of this pull request?

Adds package math/base/special/sqrtpif

This pull request:

Related Issues

Does this pull request have any related issues?

  • Test cases are failing due to values unaccurate more than tolerance.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 15, 2024
@gururaj1512
Copy link
Member Author

@gunjjoshi, The test cases are failing for this package. Can you review main.js and point out if something is wrong.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 15, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 17, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrtpif $\color{green}169/169$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}169/169$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte
Copy link
Member

kgryte commented Nov 25, 2024

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 25, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 25, 2024
@gururaj1512
Copy link
Member Author

@gunjjoshi, PR is ready for a review.

@gunjjoshi
Copy link
Member

@gururaj1512 Can you please modify the JS and C benchmarks to pre-compute the values, outside the loop? This applies to the JS examples as well.

@gunjjoshi
Copy link
Member

Also, @gururaj1512, you'll need to add the f suffix after floating-point numbers in all C files in this PR.

@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 7, 2024
@gururaj1512
Copy link
Member Author

Also, @gururaj1512, you'll need to add the f suffix after floating-point numbers in all C files in this PR.

@gunjjoshi, Updated the code as suggested. Ready for review

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gururaj1512!

Did another review pass after @gunjjoshi's and this PR should be ready to land now.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 15, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 15, 2024
@Planeshifter Planeshifter merged commit aa5c7a8 into stdlib-js:develop Dec 15, 2024
19 of 20 checks passed
@gururaj1512 gururaj1512 deleted the sqrtpif branch December 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants