feat: add `math/base/special/lcmf` #3096

Harsh-Mathur-1503 · 2024-11-11T11:22:36Z

Resolves a part of #649.

Description

What is the purpose of this pull request?

This pull request:

resolves part of [RFC]: Add C implementations to base special math functions (tracking issue) #649 by adding C implementation for math/base/special/lcmf.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Harsh-Mathur-1503 · 2024-11-11T12:59:03Z

@gunjjoshi I've worked on this package lcmf
Kindly review it

lib/node_modules/@stdlib/math/base/special/lcmf/README.md

lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Harsh-Mathur-1503 · 2024-11-12T05:23:19Z

@gunjjoshi I've done changes as requested by you
Kindly review it again for the same

lib/node_modules/@stdlib/math/base/special/lcmf/README.md

…nchmark.c Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Signed-off-by: Harsh Mathur <[email protected]>

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Signed-off-by: Harsh Mathur <[email protected]>

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

stdlib-bot · 2024-11-17T05:05:39Z

Coverage Report

No coverage information available.

Harsh-Mathur-1503 · 2024-11-17T06:13:04Z

@gunjjoshi Resolved all issues mentioned by you.
Kindly review it ,if it's ready to be merged.

kgryte · 2024-11-18T04:10:36Z

/stdlib merge

Harsh-Mathur-1503 · 2024-11-18T07:03:16Z

@kgryte is this ready to merge ?

lib/node_modules/@stdlib/math/base/special/lcmf/test/test.js

gunjjoshi · 2024-11-18T07:32:54Z

lib/node_modules/@stdlib/math/base/special/lcmf/test/test.js

+	v = lcmf( NaN, 10.0 );
+	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+
+	v = lcmf( 10.0, NaN );
+	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+
+	v = lcmf( NaN, NaN );
+	t.strictEqual( isnanf( v ), true, 'returns NaN' );


Let's use:

returns exprected value

here and in functions below.

kgryte · 2024-11-18T07:35:14Z

@Harsh-Mathur-1503 You'll need to address the various CI failures before this PR can be merged.

Signed-off-by: Harsh Mathur <[email protected]>

gunjjoshi · 2024-12-17T04:55:16Z

@Harsh-Mathur-1503 We now have the implementation of math/base/special/lcmf, which was done via #3098. So, we can close this PR now.

feat: add math/base/special/lcmf

7d853de

stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 11, 2024

Harsh-Mathur-1503 marked this pull request as ready for review November 11, 2024 11:23

Planeshifter self-requested a review November 11, 2024 14:05

Planeshifter changed the title ~~feat: add math/base/special/lcmf~~ feat: add math/base/special/lcmf Nov 11, 2024

Planeshifter added the Needs Review A pull request which needs code review. label Nov 11, 2024

gunjjoshi reviewed Nov 11, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Show resolved Hide resolved

gunjjoshi reviewed Nov 11, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 11, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 11, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js Outdated Show resolved Hide resolved

gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 11, 2024

Harsh-Mathur-1503 and others added 6 commits November 12, 2024 09:38

Update lib/node_modules/@stdlib/math/base/special/lcmf/README.md

09d7f6c

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/README.md

dff1b9c

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/README.md

2130160

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Merge branch 'stdlib-js:develop' into lcmf

fe9f583

resolved the changes as requested

814abec

resolved changes as requested

59090e1

Harsh-Mathur-1503 requested a review from gunjjoshi November 12, 2024 05:23

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 12, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/README.md Outdated Show resolved Hide resolved

Harsh-Mathur-1503 and others added 17 commits November 16, 2024 17:55

Update lib/node_modules/@stdlib/math/base/special/lcmf/benchmark/c/be…

5b04e9d

…nchmark.c Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update benchmark.c

dcde939

Signed-off-by: Harsh Mathur <[email protected]>

Update test.ts

6d7843d

Signed-off-by: Harsh Mathur <[email protected]>

Update example.c

d212d48

Signed-off-by: Harsh Mathur <[email protected]>

Update index.js

d28ccce

Signed-off-by: Harsh Mathur <[email protected]>

Merge branch 'stdlib-js:develop' into lcmf

78bc3c2

Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js

352a99c

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js

784cc9a

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js

5bacf39

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update manifest.json

691cfb8

Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/src/main.c

8f44972

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json

209d798

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json

ca16cf7

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json

03f16b9

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json

4b74121

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lcmf/src/main.c

ff495ab

Co-authored-by: Gunj Joshi <[email protected]> Signed-off-by: Harsh Mathur <[email protected]>

Merge branch 'stdlib-js:develop' into lcmf

9c39f1c

resolved conflicts

6f8f711

Harsh-Mathur-1503 requested a review from gunjjoshi November 17, 2024 06:13

Merge remote-tracking branch 'upstream/develop' into lcmf

ea4b01c

gunjjoshi reviewed Nov 18, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/lcmf/test/test.js Outdated Show resolved Hide resolved

gunjjoshi reviewed Nov 18, 2024

View reviewed changes

gunjjoshi mentioned this pull request Nov 18, 2024

feat: add math/base/special/lcmf #3098

Merged

1 task

Update test.js

d3343c0

Signed-off-by: Harsh Mathur <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `math/base/special/lcmf` #3096

feat: add `math/base/special/lcmf` #3096

Harsh-Mathur-1503 commented Nov 11, 2024 •

edited by gunjjoshi

Loading

Harsh-Mathur-1503 commented Nov 11, 2024

Harsh-Mathur-1503 commented Nov 12, 2024

stdlib-bot commented Nov 17, 2024

Harsh-Mathur-1503 commented Nov 17, 2024

kgryte commented Nov 18, 2024

Harsh-Mathur-1503 commented Nov 18, 2024

gunjjoshi Nov 18, 2024

kgryte commented Nov 18, 2024

gunjjoshi commented Dec 17, 2024

feat: add math/base/special/lcmf #3096

Are you sure you want to change the base?

feat: add math/base/special/lcmf #3096

Conversation

Harsh-Mathur-1503 commented Nov 11, 2024 • edited by gunjjoshi Loading

Description

Related Issues

Questions

Other

Checklist

Harsh-Mathur-1503 commented Nov 11, 2024

Harsh-Mathur-1503 commented Nov 12, 2024

stdlib-bot commented Nov 17, 2024

Coverage Report

Harsh-Mathur-1503 commented Nov 17, 2024

kgryte commented Nov 18, 2024

Harsh-Mathur-1503 commented Nov 18, 2024

gunjjoshi Nov 18, 2024

Choose a reason for hiding this comment

kgryte commented Nov 18, 2024

gunjjoshi commented Dec 17, 2024

feat: add `math/base/special/lcmf` #3096

feat: add `math/base/special/lcmf` #3096

Harsh-Mathur-1503 commented Nov 11, 2024 •

edited by gunjjoshi

Loading