Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding tests to acheive 100% coverage for blas/ext/base/dnansumkbn #3065

Closed

Conversation

Neerajpathak07
Copy link
Contributor

@Neerajpathak07 Neerajpathak07 commented Nov 6, 2024

Resolves #3046

Description

This pull request:

  • Adds a test case for every file to achieve 100% test coverage for blas/ext/base/dnansumkbn

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 6, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Neerajpathak07 Neerajpathak07 changed the title test: adding coverage for blas/ext/base/dnansumkbn #3046 test: adding coverage for blas/ext/base/dnansumkbn Nov 6, 2024
@Neerajpathak07 Neerajpathak07 deleted the test-dnansumkbn branch November 6, 2024 14:47
@Neerajpathak07 Neerajpathak07 restored the test-dnansumkbn branch November 6, 2024 14:48
@Neerajpathak07 Neerajpathak07 reopened this Nov 6, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@Neerajpathak07
Copy link
Contributor Author

Was trying to re-run the test cases so closed this PR.

@Neerajpathak07 Neerajpathak07 changed the title test: adding coverage for blas/ext/base/dnansumkbn test: adding tests to acheive 100% coverage for blas/ext/base/dnansumkbn Nov 6, 2024
@Neerajpathak07 Neerajpathak07 reopened this Nov 6, 2024
@headlessNode
Copy link
Member

@Neerajpathak07 The title is misleading. You are adding tests to dnannsumkbn not dnansumkbn. Also, add opening and closing backtick around the package name in the title.

Comment on lines +122 to +132
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;

x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);

v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Copy link
Member

@headlessNode headlessNode Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);
v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) {
var x;
var v;
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] );
v = dnannsumkbn( x.length, x, 0 );
t.strictEqual( v, 0.0, 'returns expected Value' );
t.end();
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to adhere to the Style conventions. You can find them here: https://github.com/stdlib-js/stdlib/tree/develop/docs/style-guides

Comment on lines +227 to +237
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;

x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);

v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Copy link
Member

@headlessNode headlessNode Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);
v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) {
var x;
var v;
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] );
v = dnannsumkbn( x.length, x, 0 );
t.strictEqual( v, 0.0, 'returns expected Value' );
t.end();
});

Comment on lines +66 to +76
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;

x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);

v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add it to the test.js file.

Suggested change
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);
v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Comment on lines +162 to +172
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;

x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);

v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Copy link
Member

@headlessNode headlessNode Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);
v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) {
var x;
var v;
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] );
v = dnannsumkbn( x.length, x, 0, 0 );
t.strictEqual( v, 0.0, 'returns expected Value' );
t.end();
});

Comment on lines +131 to +141
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;

x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);

v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});

Copy link
Member

@headlessNode headlessNode Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){
var x;
var v;
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]);
v =dnannsumkbn(x.length, x ,0);
t.strictEqual(v,0.0, 'returns expected Value');
t.end();
});
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) {
var x;
var v;
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] );
v = dnannsumkbn( x.length, x, 0, 0 );
t.strictEqual( v, 0.0, 'returns expected Value' );
t.end();
});

Copy link
Contributor Author

@Neerajpathak07 Neerajpathak07 Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will definitely look into the changes and create a pr again after changing the title.

@Neerajpathak07 Neerajpathak07 changed the title test: adding tests to acheive 100% coverage for blas/ext/base/dnansumkbn test: adding tests to acheive 100% coverage for blas/ext/base/dnansumkbn Nov 6, 2024
@Neerajpathak07 Neerajpathak07 deleted the test-dnansumkbn branch November 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete code coverage for blas/ext/base/dnansumkbn
3 participants