-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding tests to acheive 100% coverage for blas/ext/base/dnansumkbn #3065
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Was trying to re-run the test cases so closed this PR. |
@Neerajpathak07 The title is misleading. You are adding tests to |
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | ||
var x; | ||
var v; | ||
|
||
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | ||
|
||
v =dnannsumkbn(x.length, x ,0); | ||
t.strictEqual(v,0.0, 'returns expected Value'); | ||
t.end(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | |
var x; | |
var v; | |
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | |
v =dnannsumkbn(x.length, x ,0); | |
t.strictEqual(v,0.0, 'returns expected Value'); | |
t.end(); | |
}); | |
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { | |
var x; | |
var v; | |
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] ); | |
v = dnannsumkbn( x.length, x, 0 ); | |
t.strictEqual( v, 0.0, 'returns expected Value' ); | |
t.end(); | |
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to adhere to the Style conventions. You can find them here: https://github.com/stdlib-js/stdlib/tree/develop/docs/style-guides
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | ||
var x; | ||
var v; | ||
|
||
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | ||
|
||
v =dnannsumkbn(x.length, x ,0); | ||
t.strictEqual(v,0.0, 'returns expected Value'); | ||
t.end(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | |
var x; | |
var v; | |
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | |
v =dnannsumkbn(x.length, x ,0); | |
t.strictEqual(v,0.0, 'returns expected Value'); | |
t.end(); | |
}); | |
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { | |
var x; | |
var v; | |
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] ); | |
v = dnannsumkbn( x.length, x, 0 ); | |
t.strictEqual( v, 0.0, 'returns expected Value' ); | |
t.end(); | |
}); | |
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | ||
var x; | ||
var v; | ||
|
||
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | ||
|
||
v =dnannsumkbn(x.length, x ,0); | ||
t.strictEqual(v,0.0, 'returns expected Value'); | ||
t.end(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add it to the test.js
file.
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | |
var x; | |
var v; | |
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | |
v =dnannsumkbn(x.length, x ,0); | |
t.strictEqual(v,0.0, 'returns expected Value'); | |
t.end(); | |
}); |
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | ||
var x; | ||
var v; | ||
|
||
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | ||
|
||
v =dnannsumkbn(x.length, x ,0); | ||
t.strictEqual(v,0.0, 'returns expected Value'); | ||
t.end(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | |
var x; | |
var v; | |
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | |
v =dnannsumkbn(x.length, x ,0); | |
t.strictEqual(v,0.0, 'returns expected Value'); | |
t.end(); | |
}); | |
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ) { | |
var x; | |
var v; | |
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] ); | |
v = dnannsumkbn( x.length, x, 0, 0 ); | |
t.strictEqual( v, 0.0, 'returns expected Value' ); | |
t.end(); | |
}); | |
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | ||
var x; | ||
var v; | ||
|
||
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | ||
|
||
v =dnannsumkbn(x.length, x ,0); | ||
t.strictEqual(v,0.0, 'returns expected Value'); | ||
t.end(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tape('if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', function test( t ){ | |
var x; | |
var v; | |
x =new Float64Array([NaN , 1.0,2.0,3.0,4.0]); | |
v =dnannsumkbn(x.length, x ,0); | |
t.strictEqual(v,0.0, 'returns expected Value'); | |
t.end(); | |
}); | |
tape( 'if provided a `stride` parameter equal to `0` and the first element is NaN, the function returns 0', opts, function test( t ) { | |
var x; | |
var v; | |
x = new Float64Array( [ NaN, 1.0, 2.0, 3.0, 4.0 ] ); | |
v = dnannsumkbn( x.length, x, 0, 0 ); | |
t.strictEqual( v, 0.0, 'returns expected Value' ); | |
t.end(); | |
}); | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will definitely look into the changes and create a pr again after changing the title.
Resolves #3046
Description
This pull request:
Related Issues
This pull request:
blas/ext/base/dnansumkbn
#3046Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers