Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/gcdf #2997

Merged
merged 20 commits into from
Nov 11, 2024
Merged

feat: add math/base/special/gcdf #2997

merged 20 commits into from
Nov 11, 2024

Conversation

aayush0325
Copy link
Member

@aayush0325 aayush0325 commented Oct 9, 2024 •
edited by kgryte
Loading

Resolves part of #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/gcdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Open to reviews !!

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 9, 2024
@aayush0325
Copy link
Member Author

@Planeshifter Ready for initial review!

@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Oct 10, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 11, 2024
@kgryte kgryte added status: Blocked Issue or pull request which is current blocked. and removed status: Blocked Issue or pull request which is current blocked. labels Oct 26, 2024
@gunjjoshi gunjjoshi mentioned this pull request Nov 3, 2024
Merged
1 task
Planeshifter added a commit that referenced this pull request Nov 10, 2024
@gunjjoshi @Planeshifter
feat: add math/base/special/fmodf
7fd112c 
PR-URL: #3059
Ref: #2997
Ref: #3055
Ref: #649

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
Copy link
Member

@aayush0325 fmodf (added by @gunjjoshi in #3059) has now landed, so this branch can be rebased on the latest code on develop and updated to make use of it.

@Planeshifter Planeshifter removed the status: Blocked Issue or pull request which is current blocked. label Nov 10, 2024
@aayush0325
Copy link
Member Author

noted, will push the cnanges soon!

@aayush0325
Copy link
Member Author

aayush0325 commented Nov 11, 2024 •
edited
Loading

@Planeshifter , i've rebased the branch and made the changes but when i try to push them it looks through all the changed files (due to rebasing i think) and there's apparently a linting error in one of them so i'm not able to push my code. how to proceed here.
image

@Planeshifter
Copy link
Member

@aayush0325 You can bypass the hook by pushing with the --no-verify flag added to your git push command

aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@gunjjoshi @Planeshifter @aayush0325
feat: add math/base/special/fmodf
8e17660 
PR-URL: stdlib-js#3059
Ref: stdlib-js#2997
Ref: stdlib-js#3055
Ref: stdlib-js#649

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@aayush0325 aayush0325 force-pushed the gcdf branch 2 times, most recently from 73a539a to 604ada8 Compare November 11, 2024 14:41
@aayush0325
Copy link
Member Author

kindly let me know if i should make any other changes @Planeshifter

@Planeshifter
chore: update copyright year
3ef61a7 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Nov 11, 2024
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/special/gcdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2997
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Aayush Khanna <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f8bcfd8 into stdlib-js:develop Nov 11, 2024
17 checks passed
@aayush0325 aayush0325 deleted the gcdf branch November 11, 2024 15:24
@aayush0325 aayush0325 mentioned this pull request Nov 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@gunjjoshi gunjjoshi gunjjoshi left review comments

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aayush0325 @gunjjoshi @Planeshifter @stdlib-bot @kgryte