Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/riemann-zeta #2737

Merged
merged 16 commits into from
Nov 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: update test descriptions
gunjjoshi committed Nov 25, 2024
commit 3410526c7a2e21383616e7f2603c270ba6e3c6f3
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ tape( 'main export is a function', function test( t ) {

tape( 'if provided `NaN`, the function returns `NaN`', function test( t ) {
var v = zeta( NaN );
t.equal( isnan( v ), true, 'returns NaN when provided a NaN' );
t.equal( isnan( v ), true, 'returns expected value when provided a NaN' );
t.end();
});

@@ -80,7 +80,7 @@ tape( 'the function evaluates the Riemann zeta function for very small values',

tape( 'if evaluated at a pole (`s = 1`), the function returns `NaN`', function test( t ) {
var v = zeta( 1.0 );
t.equal( isnan( v ), true, 'returns NaN when provided 1' );
t.equal( isnan( v ), true, 'returns expected value when provided 1' );
t.end();
});

@@ -92,10 +92,10 @@ tape( 'the function returns `1` for all input values greater or equal than `56`'
s = linspace( 56.0, 100.0, 200 );
for ( i = 0; i < s.length; i++ ) {
v = zeta( s[ i ] );
t.equal( v, 1.0, 'returns 1 when provided '+s[i] );
t.equal( v, 1.0, 'returns expected value when provided '+s[i] );
}
v = zeta( PINF );
t.equal( v, 1.0, 'returns 1 when provided +infinity' );
t.equal( v, 1.0, 'returns expected value when provided +infinity' );

t.end();
});
@@ -108,11 +108,11 @@ tape( 'the function returns `0` for all even negative integers', function test(
s = linspace( -2.0, -200.0, 100 );
for ( i = 0; i < s.length; i++ ) {
v = zeta( s[ i ] );
t.equal( v, 0.0, 'returns 0 when provided '+s[i] );
t.equal( v, 0.0, 'returns expected value when provided '+s[i] );
}
s = -pow( 2.0, 32 ); // |s| is greater than MAX_INT32
v = zeta( s );
t.equal( v, 0.0, 'returns 0 when provided '+s );
t.equal( v, 0.0, 'returns expected value when provided '+s );
t.end();
});

@@ -185,13 +185,13 @@ tape( 'the function returns `+-infinity` for large negative non-integer values',

tape( 'if provided `0` (special value), the function returns `-0.5`', function test( t ) {
var v = zeta( 0.0 );
t.equal( v, -0.5, 'returns -0.5' );
t.equal( v, -0.5, 'returns expected value' );
t.end();
});

tape( 'if provided `-1` (special value), the function returns `-1/12`', function test( t ) {
var v = zeta( -1.0 );
t.equal( v, -1.0/12.0, 'returns -1/12' );
t.equal( v, -1.0/12.0, 'returns expected value' );
t.end();
});

Original file line number Diff line number Diff line change
@@ -101,10 +101,10 @@ tape( 'the function returns `1` for all input values greater or equal than `56`'
s = linspace( 56.0, 100.0, 200 );
for ( i = 0; i < s.length; i++ ) {
v = zeta( s[ i ] );
t.equal( v, 1.0, 'returns 1 when provided '+s[i] );
t.equal( v, 1.0, 'returns expected value when provided '+s[i] );
}
v = zeta( PINF );
t.equal( v, 1.0, 'returns 1 when provided +infinity' );
t.equal( v, 1.0, 'returns expected value when provided +infinity' );

t.end();
});
@@ -196,13 +196,13 @@ tape( 'the function returns `+-infinity` for large negative non-integer values',

tape( 'if provided `0` (special value), the function returns `-0.5`', opts, function test( t ) {
var v = zeta( 0.0 );
t.equal( v, -0.5, 'returns -0.5' );
t.equal( v, -0.5, 'returns expected value' );
t.end();
});

tape( 'if provided `-1` (special value), the function returns `-1/12`', opts, function test( t ) {
var v = zeta( -1.0 );
t.equal( v, -1.0/12.0, 'returns -1/12' );
t.equal( v, -1.0/12.0, 'returns expected value' );
t.end();
});