Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve examples of stats/base/dists/kumaraswamy #2605

Merged
merged 2 commits into from
Nov 11, 2024
Merged

docs: improve examples of stats/base/dists/kumaraswamy #2605

merged 2 commits into from
Nov 11, 2024

Conversation

ruthwikchikoti
Copy link
Contributor

Resolves #1632

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@ruthwikchikoti
Copy link
Contributor Author

hey @kgryte can you please review this !!!!!!!!!!!!

@ruthwikchikoti
Copy link
Contributor Author

I wanted to check if there are any issues affecting the merge of my pull request. If so, please let me know, and I'll be happy to make any necessary updates. @kgryte

@ruthwikchikoti
Copy link
Contributor Author

@kgryte waiting for your reply !!!

@ruthwikchikoti
Copy link
Contributor Author

@kgryte can you please review !!!

@ruthwikchikoti ruthwikchikoti mentioned this pull request Jul 28, 2024
Closed
3 tasks
@ruthwikchikoti
Copy link
Contributor Author

@kgryte waiting !!

@Planeshifter Planeshifter self-requested a review September 8, 2024 18:00
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 8, 2024
@Planeshifter Planeshifter changed the title issue#1632 resolved docs: improve examples of stats/base/dists/kumaraswamy Sep 8, 2024
@ruthwikchikoti
Copy link
Contributor Author

hey @Planeshifter can you please review this !! its being a long time waiting for your reply !

Planeshifter
Planeshifter approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small edits and will merge shortly.

Just for future reference, one of the reasons I didn't review this PR earlier was that the new examples contained a call to a random function that doesn't exist in our stats/base/dists namespaces, which you would have noticed if even running the example code a single time.

Reviewing PRs takes work, and you can expect quicker feedback when showing that you did the necessary work to ensure your PR is of high-quality.

But either way, thanks for your contribution, which I will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: improve examples of `stats/base/dists/kumaraswamy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2605
Closes: https://github.com/stdlib-js/stdlib/issues/1632

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Ruthwik Chikoti <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4e1c68b into stdlib-js:develop Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Needs Review A pull request which needs code review. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: improve README examples of stats/base/dists/kumaraswamy namespace
3 participants
@ruthwikchikoti @stdlib-bot @Planeshifter