Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update related packages sections #1930

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

stdlib-bot
Copy link
Contributor

This PR

  • updates the related packages section of READMEs to include links to related packages.

@stdlib-bot stdlib-bot added automated-pr Automated pull request (e.g., from a bot). Documentation Improvements, additions, or changes to documentation. labels Mar 17, 2024
@stdlib-bot stdlib-bot requested a review from a team March 17, 2024 02:23
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 17, 2024
This link should not have been removed by the workflow.
@Planeshifter Planeshifter merged commit 0616f00 into develop Mar 17, 2024
7 checks passed
@kgryte kgryte deleted the markdown-related-packages branch March 17, 2024 02:43
@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

@Planeshifter For PRs adding new packages, we need to ensure that the related packages section is empty. This is a common occurrence where contributors attempt to manually edit that section, despite the note instructing them not to.

@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

For now, it is up to reviewers to manually edit that section or leave an instruction for contributors to remove the contents, if they try to include it.

@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

@Planeshifter This is also an instance where I don't think that the Math label should have been applied. I suggest turning off the auto-labeler entirely.

@kgryte kgryte removed the Math Issue or pull request specific to math functionality. label Mar 17, 2024
@Planeshifter
Copy link
Member

Planeshifter commented Mar 17, 2024

@kgryte let's first change to only apply Math and BLAS labels if all changed files match the glob pattern. That will prevent labeling in cases like this. I will go further and also disable it for automatic PRs. Will update the config tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-pr Automated pull request (e.g., from a bot). Documentation Improvements, additions, or changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants