Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/coversin #1852

Closed
wants to merge 1 commit into from
Closed

feat: add C implementation for math/base/special/coversin #1852

wants to merge 1 commit into from

Conversation

Rejoan-Sardar
Copy link
Contributor

Resolves a part of #649 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/coversin

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 12, 2024
@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/special/coversin feat: add C implementation for math/base/special/coversin Mar 12, 2024
Pranavchiku
Pranavchiku reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot do this, as it depends on math/base/special/sin which do not have C implementation. This PR will be blocked.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. status: Blocked Issue or pull request which is current blocked. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@Rejoan-Sardar Rejoan-Sardar deleted the coversin branch March 15, 2024 14:52
@Rejoan-Sardar
Copy link
Contributor Author

lkjhgfvcdfvgbhjkl;lkjhbv****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku left review comments

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. status: Blocked Issue or pull request which is current blocked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rejoan-Sardar @Pranavchiku @Planeshifter