Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/ssumkbn2 to follow current project conventions #1747

Closed
wants to merge 25 commits into from

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Mar 7, 2024

Resolves #1542 .

Description

What is the purpose of this pull request?

Refactors @stdlib/blas/ext/base/ssumkbn2 to follow current project conventions.

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Mar 7, 2024

@vr-varad This PR cannot be accepted as is. The PR should only contain file changes for the package in question. This PR also includes all the commits from your take-map PR.

Based on the branch from which you are wanting to merge, you did not follow the contributing guide (see https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md#step-2-branch) and create a separate branch for your take-map commits. As a result your local develop branch has diverged from the main project develop branch.

Your main option at this point is to simply delete your local copy of stdlib, reclone, and start over, but this time creating a new branch before making your changes. For example,

$ git checkout -b feat/ssumkbn2

@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Mar 7, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 7, 2024
@vr-varad
Copy link
Contributor Author

vr-varad commented Mar 7, 2024

ohh.. sorry i didn't realise it
@kgryte I apologize for my negligence
I will reclone it and create a new pr u can delete this pr if required.

@vr-varad vr-varad closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Invalid question, issue, or pull request. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssumkbn2 to follow current project conventions
3 participants