Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add tooling for changelog generation #1289

Merged
merged 46 commits into from
Jun 3, 2024
Merged

build: add tooling for changelog generation #1289

merged 46 commits into from
Jun 3, 2024

Conversation

Planeshifter
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds tooling for generating changelog files for project packages.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Tools Issue or pull request related to project tooling. label Jan 29, 2024
@Planeshifter Planeshifter marked this pull request as ready for review February 2, 2024 15:31
@Planeshifter Planeshifter requested a review from kgryte February 3, 2024 16:37
kgryte
kgryte requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter apart from the ES6 which slipped in, this PR should be ready for merge. Once the final comment is resolved, I'll approve and merge.

@Planeshifter Planeshifter requested a review from kgryte June 3, 2024 17:55
kgryte
kgryte approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's go ahead and merge and address any subsequent changes in follow-up PRs...

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 3, 2024
@kgryte kgryte merged commit b45ba6c into develop Jun 3, 2024
7 checks passed
@kgryte kgryte deleted the philipp/changelog branch June 3, 2024 20:28
aman-095 pushed a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
@Planeshifter @kgryte @aman-095
build: add tooling for changelog generation
e39f25a 
PR-URL: stdlib-js#1289
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Planeshifter @kgryte