Skip to content

Commit

Permalink
fix: apply suggestions from code review
Browse files Browse the repository at this point in the history
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
  • Loading branch information
headlessNode committed Feb 25, 2025
1 parent 768e688 commit 290e2fb
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 37 deletions.
26 changes: 13 additions & 13 deletions lib/node_modules/@stdlib/blas/base/gscal/test/test.main.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,22 +192,22 @@ tape( 'the function supports specifying a stride (accessors)', function test( t
var expected;
var x;

x = toAccessorArray([
x = [
2.0, // 0
-3.0,
-5.0, // 1
7.0,
6.0 // 2
]);
expected = toAccessorArray([
];
expected = [
10.0, // 0
-3.0,
-25.0, // 1
7.0,
30.0 // 2
]);
];

gscal( 3, 5.0, x, 2 );
gscal( 3, 5.0, toAccessorArray( x ), 2 );
t.deepEqual( x, expected, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -240,22 +240,22 @@ tape( 'the function supports a negative stride (accessors)', function test( t )
var expected;
var x;

x = toAccessorArray([
x = [
2.0, // 0
-3.0,
-5.0, // 1
7.0,
6.0 // 2
]);
expected = toAccessorArray([
];
expected = [
10.0, // 0
-3.0,
-25.0, // 1
7.0,
30.0 // 2
]);
];

gscal( 3, 5.0, x, -2 );
gscal( 3, 5.0, toAccessorArray( x ), -2 );
t.deepEqual( x, expected, 'returns expected value' );
t.end();
});
Expand All @@ -277,10 +277,10 @@ tape( 'if provided a `stride` equal to `0`, the function multiplies first elemen
var expected;
var x;

x = toAccessorArray( [ 3.0, -4.0, 1.0 ]);
expected = toAccessorArray( [ 45.0, -4.0, 1.0 ] );
x = [ 3.0, -4.0, 1.0 ];
expected = [ 45.0, -4.0, 1.0 ];

gscal( x.length, 5.0, x, 0 );
gscal( x.length, 5.0, toAccessorArray( x ), 0 );
t.deepEqual( x, expected, 'returns expected value' );

t.end();
Expand Down
48 changes: 24 additions & 24 deletions lib/node_modules/@stdlib/blas/base/gscal/test/test.ndarray.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ tape( 'the function multiplies `x` by a constant (accessors)', function test( t
var expected;
var x;

x = toAccessorArray([
x = [
4.0,
2.0,
-3.0,
Expand All @@ -89,8 +89,8 @@ tape( 'the function multiplies `x` by a constant (accessors)', function test( t
2.0,
-5.0,
6.0
]);
expected = toAccessorArray([
];
expected = [
20.0,
10.0,
-15.0,
Expand All @@ -99,15 +99,15 @@ tape( 'the function multiplies `x` by a constant (accessors)', function test( t
10.0,
-25.0,
30.0
]);
];

gscal( x.length, 5.0, x, 1, 0 );
gscal( x.length, 5.0, toAccessorArray( x ), 1, 0 );
t.deepEqual( x, expected, 'returns expected value' );

x = [ 1.0, 2.0 ];
expected = [ 5.0, 10.0 ];

gscal( x.length, 5.0, x, 1, 0 );
gscal( x.length, 5.0, toAccessorArray( x ), 1, 0 );
t.deepEqual( x, expected, 'returns expected value' );

t.end();
Expand Down Expand Up @@ -181,10 +181,10 @@ tape( 'if provided a `stride` equal to `0`, the function multiplies first elemen
var expected;
var x;

x = toAccessorArray( [ 3.0, -4.0, 1.0 ]);
expected = toAccessorArray( [ 45.0, -4.0, 1.0 ] );
x = [ 3.0, -4.0, 1.0 ];
expected = [ 45.0, -4.0, 1.0 ];

gscal( x.length, 5.0, x, 0, 0 );
gscal( x.length, 5.0, toAccessorArray( x ), 0, 0 );
t.deepEqual( x, expected, 'returns expected value' );

t.end();
Expand Down Expand Up @@ -218,22 +218,22 @@ tape( 'the function supports specifying a stride (accessors)', function test( t
var expected;
var x;

x = toAccessorArray([
x = [
2.0, // 0
-3.0,
-5.0, // 1
7.0,
6.0 // 2
]);
expected = toAccessorArray([
];
expected = [
10.0, // 0
-3.0,
-25.0, // 1
7.0,
30.0 // 2
]);
];

gscal( 3, 5.0, x, 2, 0 );
gscal( 3, 5.0, toAccessorArray( x ), 2, 0 );
t.deepEqual( x, expected, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -266,22 +266,22 @@ tape( 'the function supports specifying a negative stride (accessors)', function
var expected;
var x;

x = toAccessorArray([
x = [
2.0, // 2
-3.0,
-5.0, // 1
7.0,
6.0 // 0
]);
expected = toAccessorArray([
];
expected = [
10.0, // 0
-3.0,
-25.0, // 1
7.0,
30.0 // 2
]);
];

gscal( 3, 5.0, x, -2, x.length-1 );
gscal( 3, 5.0, toAccessorArray( x ), -2, x.length-1 );
t.deepEqual( x, expected, 'returns expected value' );
t.end();
});
Expand Down Expand Up @@ -316,24 +316,24 @@ tape( 'the function supports an offset parameter (accessors)', function test( t
var expected;
var x;

x = toAccessorArray([
x = [
1.0,
2.0, // 0
3.0,
4.0, // 1
5.0,
6.0 // 2
]);
expected = toAccessorArray([
];
expected = [
1.0,
10.0,
3.0,
20.0,
5.0,
30.0
]);
];

gscal( 3, 5.0, x, 2, 1 );
gscal( 3, 5.0, toAccessorArray( x ), 2, 1 );
t.deepEqual( x, expected, 'returns expected value' );
t.end();
});
Expand Down

0 comments on commit 290e2fb

Please sign in to comment.