sqaud dataset bug fixed

[Jonathan-Chin328]

Hi, I have fixed some bugs in generic_dataset.py and run it successfully

1. The original BEGIN can't be detected from x in line 426
   (I printed x and found it is 'beginanswer' which without the space)
2. A simple misnomer of variable

Also, I have some problems but don't know how to fix them properly yet

1. Due to the different data format of prediction (compare to salesforce/decaNLP) ,
   it can't metric normally on task woz.en and wikisql

[s-jse]

Thank you @Jonathan-Chin328 for this PR!

We don't usually use this codebase for datasets other than Almond (tasks/almond_dataset.py), so they can break easily when we are making changes.
If you can add a small test for SQuAD like our Almond dataset tests, we can make sure we keep the code compatible with it.

To add tests for a new dataset, you would need to:

1. Add a very very small subset of that dataset in the tests/dataset folder
2. Add a test command in tests/test.sh

Similarly, for datasets that don't currently work, if you add a test for them it will be much easier for us to fix and then maintain them.

[Jonathan-Chin328]

Thanks for your response!
I have added the datasets of some tasks.

[Jonathan-Chin328]

I found that you have changed the output format of data preparing function few days ago(task.get_splits in train.py line 107),
which made all the others task can't work.
So I think I would just provide the datasets of the other tasks first~

[Mehrad0711]

Hi @Jonathan-Chin328 ,
Was wondering if you're still interested in working on this?
Otherwise, I'll close this PR and submit an issue instead.

[Jonathan-Chin328]

Hi Mehrad Moradshahi, Thanks for your reply. I'm not working on the related project now. Trouble you to close the PR, thanks. Jonathan Mehrad Moradshahi ***@***.***> 於 2021年11月12日 週五 上午6:11寫道：

…

Hi @Jonathan-Chin328 <https://github.com/Jonathan-Chin328> , Was wondering if you're still interested in working on this? Otherwise, I'll close this PR and submit and issue instead. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASK5K5QKXS4Y4VRF7AIJENLULQ5R3ANCNFSM4XAQOZOA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Mehrad0711]

Using #231 to track the issue.