chore: Apply Clippy lint comparison_chain

[jbencin]

Description

Apply Clippy lint comparison_chain, which finds places where if ... else if statements can be replaced with match a.cmp(b)

There were a few locations where I didn't want to make this change, because I felt it would decrease readability by increasing the indent level for a large segment of code. I added #[allow(clippy::comparison_chain)] so Clippy will ignore them

[kantai]

This lint feels strictly worse than what it replaces to me. If others feel differently, that’s okay with me, but for my part, it just seems to decrease readability by a good amount (not only because I have to remember the directionality of cmp, but because I have to look back to the match opening to even see what’s being compared)

[jbencin]

@kantai I had mixed feelings on this, and some of the suggestions I skipped for this reason. Some of these do still result in more lines/indentation, but I think doing the cmp once and then matching the result is more clear than repeatedly comparing the same two things in an if ... else if ... else statement

I have to remember the directionality of cmp

It's intuitive, it's left-to-right just like you would read it. For example, 2.cmp(&4) returns Ordering::Less