-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extend the default block_proposal_timeout
to 4 hours
#5768
base: develop
Are you sure you want to change the base?
Conversation
@obycode we are not sure whether the failures we are seeing are due to flakiness (probably) or a bug introduced by this PR (unlikely). In all cases, we are updating the branch, which will re-run the tests. |
Thanks, I'll take a look. I agree, it seems unlikely that any test was inadvertently depending on that timeout, since it was already 10 minutes, but I'll investigate. |
Ok, I pushed a commit to fix the flakiness in
You can see the approval arrived just before the timeout, so just a little more time and it would've been fine. I'll bump that from 30s to 60s. I need to take a closer look at |
I'm tempted to just bump all 30s timeouts to 60s. |
|
Until #5729 is implemented, then there is no point in rejecting a block from a miner, no matter how late it is, since no other miner will ever try to extend into its tenure.
Fixes #5753