Fix: better win detection on restart #5752
Merged
+239
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
previously approved these changes
Jan 27, 2025
Well, let me see if this PR addresses that too. |
It doesn't! But now I have a test for it. Opened issue #5754 |
obycode
previously approved these changes
Jan 27, 2025
obycode
previously approved these changes
Jan 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
I went ahead an fixed the conflict (it was just the Changelog) |
hstove
previously approved these changes
Jan 29, 2025
obycode
previously approved these changes
Jan 29, 2025
|
Sorry you gotta update the test to use |
hstove
approved these changes
Jan 29, 2025
obycode
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves how miners detect whether or not they won a sortition. This mostly impacts miners on restarts, because previously they used in-memory state to detect a winning sortition (#5750)