-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve logging in StackerDBListener
#5747
base: develop
Are you sure you want to change the base?
Conversation
Log the approved weight and the rejected weight and make the naming consistent.
Would it be better to just log the percentages instead of the raw numbers here? I'm realizing for me, having just the percentages would be nicer. |
Ok, I added the percentages as well in aa1adf5. |
aa1adf5
to
c03f633
Compare
Just a general question, sometimes I see we update changelog with logging improvements. Would this be necessary for this PR? Or is it enough to just say "Various logging improvements" under the changelog? |
My general thinking is that logging changes are not changelog worthy unless it's something significant like a major cleanup of logs, or addressing some specific pain point. |
Yeah, I'd think just adding |
Ok, I'll add that. I'll wait til one of the other PRs with changelog entries merge first to avoid conflicts. |
Changelog entry added in 3edfbd1. |
Log the approved weight and the rejected weight and make the naming consistent.