New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clippy lints `approx_constant`, `assertions_on_constants`, `assign_op_pattern`, and `bool_assert_comparison` #5745

Open

jferrant wants to merge 5 commits into develop from chore/clippy-assertions-assign-op-approx-constant

Collaborator

jferrant commented Jan 24, 2025

No description provided.


          Fix approx_constant, assertions_on_constants, assign_op_pattern, and …

832d561

…bool_assert_comparison throughout stacks-core

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant requested review from jcnelson, hstove, kantai, obycode and jbencin

January 24, 2025 22:36

jferrant requested review from a team as code owners

January 24, 2025 22:36

jbencin reviewed

View reviewed changes

stackslib/src/burnchains/bitcoin/spv.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/boot/pox_2_tests.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/boot/pox_2_tests.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/db/blocks.rs Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/burnchains/tests/mod.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/db/blocks.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/index/marf.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/index/marf.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/connection.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/connection.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/dns.rs Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/mod.rs Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/server.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/tests/httpcore.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

testnet/stacks-node/src/tests/nakamoto_integrations.rs Outdated Show resolved Hide resolved

jbencin previously approved these changes

View reviewed changes

Contributor

jbencin left a comment

Made some style suggestions but everything looks correct

jbencin added the lint label

jferrant added 2 commits

January 29, 2025 10:02


          Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

272dd27

… into chore/clippy-assertions-assign-op-approx-constant


          Code review comments

32ca6e5

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant dismissed jbencin’s stale review via

32ca6e5

January 29, 2025 20:43

jferrant requested a review from jbencin

January 29, 2025 20:47


          Code review comments part 2

0903fdd

Signed-off-by: Jacinta Ferrant <[email protected]>


          Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

bbfc775

… into chore/clippy-assertions-assign-op-approx-constant

jbencin approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jbencin jbencin approved these changes

jcnelson Awaiting requested review from jcnelson

hstove Awaiting requested review from hstove

kantai Awaiting requested review from kantai

obycode Awaiting requested review from obycode

At least 2 approving reviews are required to merge this pull request.

Labels

lint