New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply `clippy::unnecesary_to_owned` and `clippy::unwrap_or_default` fixes throughout stacks core #5741

Merged

jbencin merged 5 commits into develop from chore/clippy-unnecesary-to-owned-unwrap-or-default

Jan 28, 2025

Collaborator

jferrant commented Jan 23, 2025

to run cargo clippy --tests --all-features -- -Aclippy::all -W clippy::unnecessary_to_owned -W clippy::unwrap_or_default


          Apply clippy::unnecessary_to_owned and clippy::unwrap_or_default

f95abc5

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant requested review from jcnelson, hstove, kantai, obycode and jbencin

January 23, 2025 22:49

jferrant requested a review from a team as a code owner

January 23, 2025 22:49

jbencin reviewed

View reviewed changes

stackslib/src/burnchains/bitcoin/blocks.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/burnchains/tests/mod.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/index/test/marf.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/chainstate/stacks/index/test/node.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/db.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/dns.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

stackslib/src/net/dns.rs Outdated Show resolved Hide resolved

jbencin reviewed

View reviewed changes

testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs Outdated Show resolved Hide resolved

jbencin added the lint label

jferrant added 3 commits

January 24, 2025 10:16


          Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

769c94d

… into chore/clippy-unnecesary-to-owned-unwrap-or-default


          CRC: cleanup

4a6bc74

Signed-off-by: Jacinta Ferrant <[email protected]>


          CRC: replace StacksPrivateKey::new with StacksPrivateKey::random and …

ccbf1af

…remove default implementation

Signed-off-by: Jacinta Ferrant <[email protected]>

jferrant requested a review from a team as a code owner

January 24, 2025 18:30

jbencin approved these changes

View reviewed changes

obycode reviewed

View reviewed changes

Contributor

obycode left a comment

LGTM assuming that failing test passes on retry.


          Merge branch 'develop' into chore/clippy-unnecesary-to-owned-unwrap-o…

b2c34d9

…r-default

obycode approved these changes

View reviewed changes

jbencin added this pull request to the merge queue

Merged via the queue into develop with commit 36d49b0

187 of 188 checks passed

jbencin deleted the chore/clippy-unnecesary-to-owned-unwrap-or-default branch

January 28, 2025 15:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jbencin jbencin approved these changes

obycode obycode approved these changes

jcnelson Awaiting requested review from jcnelson

hstove Awaiting requested review from hstove

kantai Awaiting requested review from kantai

Labels

lint