Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: StacksAddress and PrincipalData cleanup #5739

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

jcnelson
Copy link
Member

This refactor makes it easier to use StacksAddress and PrincipalData.

@jcnelson jcnelson requested review from a team as code owners January 23, 2025 18:01
jferrant
jferrant previously approved these changes Jan 23, 2025
wileyj
wileyj previously approved these changes Jan 23, 2025
@wileyj wileyj enabled auto-merge January 23, 2025 18:02
obycode
obycode previously approved these changes Jan 23, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbencin
jbencin previously approved these changes Jan 23, 2025
@jcnelson jcnelson dismissed stale reviews from jbencin, obycode, wileyj, and jferrant via cd8f5ff January 23, 2025 18:05
@jcnelson jcnelson requested a review from a team as a code owner January 23, 2025 18:05
jbencin
jbencin previously approved these changes Jan 23, 2025
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj wileyj added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit 43d4ee9 Jan 23, 2025
175 of 188 checks passed
@wileyj wileyj deleted the chore/address-refactor branch January 23, 2025 19:16
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants