chore: Apply Clippy lint redundant_clone

[jbencin]

Description

Apply Clippy lint redundant_clone. Finds unnecessary calls to .clone(), .to_string(), .to_owned(), etc. This is a nursery lint, and there are still a lot of false positives if you run it, but I think I got all the instances I could

[jferrant]

I think there are some issues in the test cache.

[jbencin]

Fixed CI build failures (due to code gated by --feature=monitoring_prom). I've tested with:

cargo build --all-targets --all-features

To be sure that there's no more hidden failures in code gated by feature flags

[obycode]

Wow, that's a lot of unnecessary clones! I'm curious if this will have any performance impact. I noticed one place that I think could be improved and will approve after the merge conflict is resolved and tests still pass.

[jbencin]

I'm curious if this will have any performance impact

Almost all of these are in test code, so node operators shouldn't really see any change, but we might notice cargo test running a bit faster and using less memory

Keep in mind manually optimizing test code has a much larger performance impact because it's built with -o0, so you can be confident that the compiler wasn't optimizing away any of these unnecessary allocations

[obycode]

Approved assuming tests pass

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.