Fix/bitcoind forking test signerdb state #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
…te to accomodate for unknown consensus hashes Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
reviewed
Jan 8, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
… into fix/bitcoind-forking-test-signerdb-state
kantai
approved these changes
Jan 9, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5673
This check_block_against_signer_db_state is meant to be a minimal check post other validation checks in case some block got approved between our block proposal submission for validation and its return. It was incorrectly querying signer db purely based on height and state and ignoring consensus hash. This check makes it use bare minimum checks to include both a check against the parent consensus hash in the case of a tenure change and a check against the current cosnensus hash to ensure the proposed height is acceptable.